<div dir="ltr">Hi Andreas,<div><br></div><div>Similar patch for <span style="font-size:12.8px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">varyings linking was pushed 4 years ago, so I think this patch should be also stable.</span></div><div> </div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Aug 28, 2018 at 12:20 AM, Andres Gomez <span dir="ltr"><<a href="mailto:agomez@igalia.com" target="_blank">agomez@igalia.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Vadym, should we also include this in the stable queues ?<br>
<div><div class="h5"><br>
<br>
On Mon, 2018-08-20 at 16:31 +0300, vadym.shovkoplias wrote:<br>
> From Section 4.3.4 (Inputs) of the GLSL 1.50 spec:<br>
> <br>
> "Only the input variables that are actually read need to be written<br>
> by the previous stage; it is allowed to have superfluous<br>
> declarations of input variables."<br>
> <br>
> Fixes:<br>
> * interstage-multiple-shader-<wbr>objects.shader_test<br>
> <br>
> Bugzilla: <a href="https://bugs.freedesktop.org/show_bug.cgi?id=101247" rel="noreferrer" target="_blank">https://bugs.freedesktop.org/<wbr>show_bug.cgi?id=101247</a><br>
> Signed-off-by: Vadym Shovkoplias <<a href="mailto:vadym.shovkoplias@globallogic.com">vadym.shovkoplias@<wbr>globallogic.com</a>><br>
> ---<br>
> src/compiler/glsl/link_<wbr>interface_blocks.cpp | 8 +++++++-<br>
> 1 file changed, 7 insertions(+), 1 deletion(-)<br>
> <br>
> diff --git a/src/compiler/glsl/link_<wbr>interface_blocks.cpp b/src/compiler/glsl/link_<wbr>interface_blocks.cpp<br>
> index e5eca9460e..801fbcd5d9 100644<br>
> --- a/src/compiler/glsl/link_<wbr>interface_blocks.cpp<br>
> +++ b/src/compiler/glsl/link_<wbr>interface_blocks.cpp<br>
> @@ -417,9 +417,15 @@ validate_interstage_inout_<wbr>blocks(struct gl_shader_program *prog,<br>
> * write to any of the pre-defined outputs (e.g. if the vertex shader<br>
> * does not write to gl_Position, etc), which is allowed and results in<br>
> * undefined behavior.<br>
> + *<br>
> + * From Section 4.3.4 (Inputs) of the GLSL 1.50 spec:<br>
> + *<br>
> + * "Only the input variables that are actually read need to be written<br>
> + * by the previous stage; it is allowed to have superfluous<br>
> + * declarations of input variables."<br>
> */<br>
> if (producer_def == NULL &&<br>
> - !is_builtin_gl_in_block(var, consumer->Stage)) {<br>
> + !is_builtin_gl_in_block(var, consumer->Stage) && var->data.used) {<br>
> linker_error(prog, "Input block `%s' is not an output of "<br>
> "the previous stage\n", var->get_interface_type()-><wbr>name);<br>
> return;<br>
-- <br>
</div></div>Br,<br>
<br>
Andres<br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><font size="-1"><br><span style="vertical-align:baseline;font-variant:normal;font-style:normal;font-size:12px;background-color:transparent;text-decoration:none;font-family:Arial;font-weight:bold">Vadym Shovkoplias | Senior Software Engineer</span><br><span style="vertical-align:baseline;font-variant:normal;font-style:normal;font-size:12px;background-color:transparent;text-decoration:none;font-family:Arial;font-weight:normal">GlobalLogic</span><br><span style="vertical-align:baseline;font-variant:normal;font-style:normal;font-size:12px;background-color:transparent;text-decoration:none;font-family:Arial;font-weight:normal"></span></font><font size="-1"><span style="vertical-align:baseline;font-variant:normal;font-style:normal;font-size:12px;background-color:transparent;text-decoration:none;font-family:Arial;font-weight:normal"><span><font color="#888888"><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:12.8px">P </span><a style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:12.8px">+380.57.766.7667</a></font></span> M +3.8050.931.7304 S vadym.shovkoplias</span><br><a href="http://www.globallogic.com/" target="_blank"><span style="font-size:12px;font-family:Arial;color:#1155cc;background-color:transparent;font-weight:normal;font-style:normal;font-variant:normal;text-decoration:underline;vertical-align:baseline">www.globallogic.com</span></a><span style="vertical-align:baseline;font-variant:normal;font-style:normal;font-size:12px;background-color:transparent;text-decoration:none;font-family:Arial;font-weight:normal"></span><br><a href="http://www.globallogic.com/" target="_blank"><span style="font-size:12px;font-family:Arial;color:#1155cc;background-color:transparent;font-weight:normal;font-style:normal;font-variant:normal;text-decoration:underline;vertical-align:baseline"></span></a><br><a href="http://www.globallogic.com/email_disclaimer.txt" target="_blank"><span style="font-size:11px;font-family:Arial;color:#1155cc;background-color:transparent;font-weight:normal;font-style:normal;font-variant:normal;text-decoration:underline;vertical-align:baseline">http://www.globallogic.com/email_disclaimer.txt</span></a><span style="vertical-align:baseline;font-variant:normal;font-style:normal;font-size:11px;background-color:transparent;text-decoration:none;font-family:Arial;font-weight:normal"></span></font></div></div></div></div></div></div></div>
</div>