<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">There was a test that failed, but I
think it might be flakyness.</div>
<div class="moz-cite-prefix">I'm retrying one more time. Will get
back to you in ~1h.</div>
<div class="moz-cite-prefix"><br>
</div>
<div class="moz-cite-prefix">-</div>
<div class="moz-cite-prefix">Lionel<br>
</div>
<div class="moz-cite-prefix"><br>
</div>
<div class="moz-cite-prefix">On 07/09/2018 10:32, Sergii Romantsov
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CALt4EUT9D+Q2mQcow+YAcDj7zfCGbTCz1R=xZD26J_Ar7J=+OQ@mail.gmail.com">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<div dir="ltr">Hello, Lionel.
<div>Any regression with CI?</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Thu, Sep 6, 2018 at 12:33 PM, Lionel
Landwerlin <span dir="ltr"><<a
href="mailto:lionel.g.landwerlin@intel.com"
target="_blank" moz-do-not-send="true">lionel.g.landwerlin@intel.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">Giving it
a run through CI and I'll push after.<br>
<br>
Thanks!
<div class="HOEnZb">
<div class="h5"><br>
<br>
On 06/09/2018 09:07, Sergii Romantsov wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
Seems in case of 32-bit library, usage of msse2 makes<br>
some stack corruption or incorrect instructions.<br>
Usage with mstackrealign fixes that case.<br>
<br>
v2: Fixed meson.<br>
<br>
v3: Definition of c_sse2_args moved on the top
(L.Landwerlin).<br>
Added mstackrealign for Android's mks where
msee4.1 is used.<br>
<br>
v4: Added for Vulkan also.<br>
<br>
v5: Commit message correction.<br>
<br>
CC: <<a
href="mailto:mesa-stable@lists.freedesktop.org"
target="_blank" moz-do-not-send="true">mesa-stable@lists.freedesktop<wbr>.org</a>><br>
Fixes: 6b05c080f202 (i965: Compile with -msse3)<br>
Bugzilla: <a
href="https://bugs.freedesktop.org/show_bug.cgi?id=107779"
rel="noreferrer" target="_blank"
moz-do-not-send="true">https://bugs.freedesktop.org/s<wbr>how_bug.cgi?id=107779</a><br>
Signed-off-by: Sergii Romantsov <<a
href="mailto:sergii.romantsov@globallogic.com"
target="_blank" moz-do-not-send="true">sergii.romantsov@globallogic.<wbr>com</a>><br>
Reviewed-by: Dylan Baker <<a
href="mailto:dylan@pnwbakers.com" target="_blank"
moz-do-not-send="true">dylan@pnwbakers.com</a>><br>
Reviewed-by: Emil Velikov <<a
href="mailto:emil.velikov@collabora.com"
target="_blank" moz-do-not-send="true">emil.velikov@collabora.com</a>><br>
Reviewed-by: Lionel Landwerlin <<a
href="mailto:lionel.g.landwerlin@intel.com"
target="_blank" moz-do-not-send="true">lionel.g.landwerlin@intel.com</a><wbr>><br>
---<br>
src/intel/<a href="http://Makefile.vulkan.am"
rel="noreferrer" target="_blank"
moz-do-not-send="true">Makefile.vulkan.am</a>
| 2 +-<br>
src/intel/meson.build | 1 +<br>
src/intel/vulkan/meson.build | 4 ++--<br>
src/mesa/<a href="http://Android.libmesa_dricore.mk"
rel="noreferrer" target="_blank"
moz-do-not-send="true">Android.libmesa_drico<wbr>re.mk</a>
| 2 +-<br>
src/mesa/<a href="http://Android.libmesa_sse41.mk"
rel="noreferrer" target="_blank"
moz-do-not-send="true">Android.libmesa_sse41<wbr>.mk</a>
| 2 +-<br>
src/mesa/drivers/dri/i965/Make<wbr><a
href="http://file.am" moz-do-not-send="true">file.am</a>
| 2 +-<br>
src/mesa/drivers/dri/i965/meso<wbr>n.build | 6
+++---<br>
7 files changed, 10 insertions(+), 9 deletions(-)<br>
<br>
diff --git a/src/intel/<a
href="http://Makefile.vulkan.am" rel="noreferrer"
target="_blank" moz-do-not-send="true">Makefile.vulkan.am</a>
b/src/intel/<a href="http://Makefile.vulkan.am"
rel="noreferrer" target="_blank"
moz-do-not-send="true">Makefile.vulkan.am</a><br>
index 9555d98..d511263 100644<br>
--- a/src/intel/<a href="http://Makefile.vulkan.am"
rel="noreferrer" target="_blank"
moz-do-not-send="true">Makefile.vulkan.am</a><br>
+++ b/src/intel/<a href="http://Makefile.vulkan.am"
rel="noreferrer" target="_blank"
moz-do-not-send="true">Makefile.vulkan.am</a><br>
@@ -104,7 +104,7 @@ noinst_LTLIBRARIES +=
$(VULKAN_PER_GEN_LIBS)<br>
VULKAN_CFLAGS = \<br>
$(AM_CFLAGS) \<br>
- -msse2<br>
+ -msse2 -mstackrealign<br>
VULKAN_CPPFLAGS = \<br>
-I$(top_srcdir)/src/compiler \<br>
diff --git a/src/intel/meson.build
b/src/intel/meson.build<br>
index b3dcbdc..3c57e79 100644<br>
--- a/src/intel/meson.build<br>
+++ b/src/intel/meson.build<br>
@@ -18,6 +18,7 @@<br>
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
USE OR OTHER DEALINGS IN THE<br>
# SOFTWARE.<br>
+c_sse2_args = ['-msse2', '-mstackrealign']<br>
inc_intel = include_directories('.')<br>
subdir('blorp')<br>
diff --git a/src/intel/vulkan/meson.build
b/src/intel/vulkan/meson.build<br>
index e11bcb0..f1beb1d 100644<br>
--- a/src/intel/vulkan/meson.build<br>
+++ b/src/intel/vulkan/meson.build<br>
@@ -102,7 +102,7 @@ foreach g : [['70',
['gen7_cmd_buffer.c']], ['75', ['gen7_cmd_buffer.c']],<br>
inc_vulkan_wsi,<br>
],<br>
c_args : [<br>
- c_vis_args, no_override_init_args, '-msse2',<br>
+ c_vis_args, no_override_init_args, c_sse2_args,<br>
'-DGEN_VERSIONx10=@0@'.format(<wbr>_gen),<br>
],<br>
dependencies : [dep_libdrm, dep_valgrind,
idep_nir_headers],<br>
@@ -146,7 +146,7 @@ anv_deps = [<br>
anv_flags = [<br>
c_vis_args,<br>
no_override_init_args,<br>
- '-msse2',<br>
+ c_sse2_args,<br>
]<br>
if with_platform_x11<br>
diff --git a/src/mesa/<a
href="http://Android.libmesa_dricore.mk"
rel="noreferrer" target="_blank"
moz-do-not-send="true">Android.libmesa_dri<wbr>core.mk</a>
b/src/mesa/<a href="http://Android.libmesa_dricore.mk"
rel="noreferrer" target="_blank"
moz-do-not-send="true">Android.libmesa_dri<wbr>core.mk</a><br>
index 34fd858..7921177 100644<br>
--- a/src/mesa/<a
href="http://Android.libmesa_dricore.mk"
rel="noreferrer" target="_blank"
moz-do-not-send="true">Android.libmesa_dri<wbr>core.mk</a><br>
+++ b/src/mesa/<a
href="http://Android.libmesa_dricore.mk"
rel="noreferrer" target="_blank"
moz-do-not-send="true">Android.libmesa_dri<wbr>core.mk</a><br>
@@ -49,7 +49,7 @@ ifeq ($(ARCH_X86_HAVE_SSE4_1),true)<br>
LOCAL_WHOLE_STATIC_LIBRARIES := \<br>
libmesa_sse41<br>
LOCAL_CFLAGS := \<br>
- -msse4.1 \<br>
+ -msse4.1 -mstackrealign \<br>
-DUSE_SSE41<br>
endif<br>
diff --git a/src/mesa/<a
href="http://Android.libmesa_sse41.mk"
rel="noreferrer" target="_blank"
moz-do-not-send="true">Android.libmesa_sse<wbr>41.mk</a>
b/src/mesa/<a href="http://Android.libmesa_sse41.mk"
rel="noreferrer" target="_blank"
moz-do-not-send="true">Android.libmesa_sse<wbr>41.mk</a><br>
index da40f43..de19a1f 100644<br>
--- a/src/mesa/<a
href="http://Android.libmesa_sse41.mk"
rel="noreferrer" target="_blank"
moz-do-not-send="true">Android.libmesa_sse<wbr>41.mk</a><br>
+++ b/src/mesa/<a
href="http://Android.libmesa_sse41.mk"
rel="noreferrer" target="_blank"
moz-do-not-send="true">Android.libmesa_sse<wbr>41.mk</a><br>
@@ -34,7 +34,7 @@ LOCAL_SRC_FILES += \<br>
$(X86_SSE41_FILES)<br>
LOCAL_CFLAGS := \<br>
- -msse4.1<br>
+ -msse4.1 -mstackrealign<br>
LOCAL_C_INCLUDES := \<br>
$(MESA_TOP)/src/mapi \<br>
diff --git a/src/mesa/drivers/dri/i965/Ma<wbr><a
href="http://kefile.am" moz-do-not-send="true">kefile.am</a>
b/src/mesa/drivers/dri/i965/Ma<wbr><a
href="http://kefile.am" moz-do-not-send="true">kefile.am</a><br>
index 889d4c6..0afa7a2 100644<br>
--- a/src/mesa/drivers/dri/i965/Ma<wbr><a
href="http://kefile.am" moz-do-not-send="true">kefile.am</a><br>
+++ b/src/mesa/drivers/dri/i965/Ma<wbr><a
href="http://kefile.am" moz-do-not-send="true">kefile.am</a><br>
@@ -44,7 +44,7 @@ AM_CFLAGS = \<br>
$(WNO_OVERRIDE_INIT) \<br>
$(LIBDRM_CFLAGS) \<br>
$(VALGRIND_CFLAGS) \<br>
- -msse2<br>
+ -msse2 -mstackrealign<br>
AM_CXXFLAGS = $(AM_CFLAGS)<br>
diff --git a/src/mesa/drivers/dri/i965/me<wbr>son.build
b/src/mesa/drivers/dri/i965/me<wbr>son.build<br>
index 6c94f4a..b95e2d7 100644<br>
--- a/src/mesa/drivers/dri/i965/me<wbr>son.build<br>
+++ b/src/mesa/drivers/dri/i965/me<wbr>son.build<br>
@@ -142,7 +142,7 @@ foreach v : ['40', '45', '50',
'60', '70', '75', '80', '90', '100', '110']<br>
['genX_blorp_exec.c', 'genX_state_upload.c',
gen_xml_pack],<br>
include_directories : [inc_common, inc_intel,
inc_dri_common],<br>
c_args : [<br>
- c_vis_args, no_override_init_args, '-msse2',<br>
+ c_vis_args, no_override_init_args, c_sse2_args,<br>
'-DGEN_VERSIONx10=@0@'.format(<wbr>v),<br>
],<br>
dependencies : [dep_libdrm, idep_nir_headers],<br>
@@ -183,8 +183,8 @@ libi965 = static_library(<br>
include_directories : [<br>
inc_common, inc_intel, inc_dri_common, inc_util,
inc_drm_uapi,<br>
],<br>
- c_args : [c_vis_args, no_override_init_args,
'-msse2'],<br>
- cpp_args : [cpp_vis_args, '-msse2'],<br>
+ c_args : [c_vis_args, no_override_init_args,
c_sse2_args],<br>
+ cpp_args : [cpp_vis_args, c_sse2_args],<br>
link_with : [<br>
i965_gen_libs, libintel_common, libintel_dev,
libisl, libintel_compiler,<br>
libblorp,<br>
</blockquote>
<br>
<br>
</div>
</div>
<div class="HOEnZb">
<div class="h5">
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org"
target="_blank" moz-do-not-send="true">mesa-dev@lists.freedesktop.org</a><br>
<a
href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev"
rel="noreferrer" target="_blank"
moz-do-not-send="true">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</div>
</div>
</blockquote>
</div>
<br>
<br clear="all">
<div><br>
</div>
-- <br>
<div class="gmail_signature" data-smartmail="gmail_signature">
<div dir="ltr">
<div>
<div dir="ltr">
<div dir="ltr">Sergii Romantsov<br>
</div>
<div dir="ltr">
<div
style="margin:0px;padding:0px;color:rgb(23,43,77);font-family:-apple-system,BlinkMacSystemFont,"Segoe
UI",Roboto,Oxygen,Ubuntu,"Fira
Sans","Droid Sans","Helvetica
Neue",sans-serif;font-size:14px">GlobalLogic
Inc.<br>
<a href="http://www.globallogic.com/" rel="nofollow"
style="color:rgb(0,82,204)" target="_blank"
moz-do-not-send="true">www.globallogic.com</a><br>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<pre class="moz-quote-pre" wrap="">_______________________________________________
mesa-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a>
<a class="moz-txt-link-freetext" href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a>
</pre>
</blockquote>
<p><br>
</p>
</body>
</html>