<div dir="ltr"><div class="gmail_quote"><div dir="ltr">On Mon, Sep 10, 2018 at 2:53 PM Bas Nieuwenhuizen <<a href="mailto:bas@basnieuwenhuizen.nl">bas@basnieuwenhuizen.nl</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Mon, Sep 10, 2018 at 8:59 PM Jason Ekstrand <<a href="mailto:jason@jlekstrand.net" target="_blank">jason@jlekstrand.net</a>> wrote:<br>
><br>
> I recommend CCing stable (I just did on mine) so that it goes into 18.2.<br>
<br>
You're right, added the CC in the commit when pushing. This has a<br>
dependency on 34a17a48d440add1da619efd054b50b210cd869b, which hasn't<br>
been marked though.<br></blockquote><div><br></div><div>I forgot the CC when I pushed mine so I sent a manual e-mail to mesa-stable asking them to back-port it and the XML/header update.</div><div><br></div><div>--Jason<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
><br>
> On Mon, Sep 10, 2018 at 1:35 PM Bas Nieuwenhuizen <<a href="mailto:bas@basnieuwenhuizen.nl" target="_blank">bas@basnieuwenhuizen.nl</a>> wrote:<br>
>><br>
>> ---<br>
>>  src/amd/vulkan/radv_device.c      | 7 +++++++<br>
>>  src/amd/vulkan/radv_extensions.py | 2 +-<br>
>>  2 files changed, 8 insertions(+), 1 deletion(-)<br>
>><br>
>> diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c<br>
>> index 53f99a8cecd..7917ed7ffe5 100644<br>
>> --- a/src/amd/vulkan/radv_device.c<br>
>> +++ b/src/amd/vulkan/radv_device.c<br>
>> @@ -821,6 +821,13 @@ void radv_GetPhysicalDeviceFeatures2(<br>
>>                         features->inheritedConditionalRendering = false;<br>
>>                         break;<br>
>>                 }<br>
>> +               case VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_VERTEX_ATTRIBUTE_DIVISOR_FEATURES_EXT: {<br>
>> +                       VkPhysicalDeviceVertexAttributeDivisorFeaturesEXT *features =<br>
>> +                               (VkPhysicalDeviceVertexAttributeDivisorFeaturesEXT *)ext;<br>
>> +                       features->vertexAttributeInstanceRateDivisor = VK_TRUE;<br>
>> +                       features->vertexAttributeInstanceRateZeroDivisor = VK_TRUE;<br>
>> +                       break;<br>
>> +               }<br>
>>                 default:<br>
>>                         break;<br>
>>                 }<br>
>> diff --git a/src/amd/vulkan/radv_extensions.py b/src/amd/vulkan/radv_extensions.py<br>
>> index b5b9c137927..fa35aabd3ba 100644<br>
>> --- a/src/amd/vulkan/radv_extensions.py<br>
>> +++ b/src/amd/vulkan/radv_extensions.py<br>
>> @@ -105,7 +105,7 @@ EXTENSIONS = [<br>
>>      Extension('VK_EXT_sampler_filter_minmax',             1, 'device->rad_info.chip_class >= CIK'),<br>
>>      Extension('VK_EXT_shader_viewport_index_layer',       1, True),<br>
>>      Extension('VK_EXT_shader_stencil_export',             1, True),<br>
>> -    Extension('VK_EXT_vertex_attribute_divisor',          2, True),<br>
>> +    Extension('VK_EXT_vertex_attribute_divisor',          3, True),<br>
>>      Extension('VK_AMD_draw_indirect_count',               1, True),<br>
>>      Extension('VK_AMD_gcn_shader',                        1, True),<br>
>>      Extension('VK_AMD_rasterization_order',               1, 'device->has_out_of_order_rast'),<br>
>> --<br>
>> 2.18.0<br>
>><br>
>> _______________________________________________<br>
>> mesa-dev mailing list<br>
>> <a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br>
>> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
</blockquote></div></div>