<div dir="ltr"><div>It's not needed in stable. This is a corner case for piglit.</div><div><br></div><div>Marek<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Jun 18, 2019 at 6:03 AM Juan A. Suarez Romero <<a href="mailto:jasuarez@igalia.com">jasuarez@igalia.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Fri, 2019-06-14 at 19:00 -0400, Marek Olšák wrote:<br>
> From: Nicolai Hähnle <<a href="mailto:nicolai.haehnle@amd.com" target="_blank">nicolai.haehnle@amd.com</a>><br>
> <br>
> This fixes piglit spec@glsl-1.50@gs-max-output.<br>
> ---<br>
<br>
<br>
Does it make sense to nominate this for stable?<br>
<br>
        J.A.<br>
<br>
>  src/gallium/drivers/radeonsi/si_get.c | 4 +++-<br>
>  1 file changed, 3 insertions(+), 1 deletion(-)<br>
> <br>
> diff --git a/src/gallium/drivers/radeonsi/si_get.c b/src/gallium/drivers/radeonsi/si_get.c<br>
> index c1bddca1a66..9496817ac84 100644<br>
> --- a/src/gallium/drivers/radeonsi/si_get.c<br>
> +++ b/src/gallium/drivers/radeonsi/si_get.c<br>
> @@ -256,21 +256,23 @@ static int si_get_param(struct pipe_screen *pscreen, enum pipe_cap param)<br>
>               return sscreen->info.chip_class <= GFX8 ?<br>
>                       PIPE_QUIRK_TEXTURE_BORDER_COLOR_SWIZZLE_R600 : 0;<br>
>  <br>
>       /* Stream output. */<br>
>       case PIPE_CAP_MAX_STREAM_OUTPUT_SEPARATE_COMPONENTS:<br>
>       case PIPE_CAP_MAX_STREAM_OUTPUT_INTERLEAVED_COMPONENTS:<br>
>               return 32*4;<br>
>  <br>
>       /* Geometry shader output. */<br>
>       case PIPE_CAP_MAX_GEOMETRY_OUTPUT_VERTICES:<br>
> -             return 1024;<br>
> +             /* gfx8 and earlier can do more, but nobody uses it because it<br>
> +              * would be a bad idea for performance. */<br>
> +             return 256;<br>
>       case PIPE_CAP_MAX_GEOMETRY_TOTAL_OUTPUT_COMPONENTS:<br>
>               return 4095;<br>
>       case PIPE_CAP_MAX_GS_INVOCATIONS:<br>
>               /* The closed driver exposes 127, but 125 is the greatest<br>
>                * number that works. */<br>
>               return 125;<br>
>  <br>
>       case PIPE_CAP_MAX_VERTEX_ATTRIB_STRIDE:<br>
>               return 2048;<br>
>  <br>
<br>
_______________________________________________<br>
mesa-stable mailing list<br>
<a href="mailto:mesa-stable@lists.freedesktop.org" target="_blank">mesa-stable@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-stable" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-stable</a></blockquote></div>