[PATCH 1/2] huawei: store modem model in MMBroadbandModemHuaweiPrivate

Aleksander Morgado aleksander at lanedo.com
Wed Aug 14 00:19:45 PDT 2013

On 14/08/13 09:03, Ben Chan wrote:
>     On 13/08/13 19:31, Dan Williams wrote:
>     >> Is mm_gdbus_* expected to be called from a plugin?  I don't find
>     any plugin
>     >> > using mm_gdbus_* and wonder if there is a reason for that.
>     > Yeah, I wondered about that.  But the core code does it, and
>     there's got
>     > to be a simple way for the plugins to easily access common properties
>     > like model/vendor/etc, so I figured why not give a try :)  I'll
>     defer to
>     > Aleksander though to see if he had some reason.
>     How about a const gchar *mm_iface_modem_get_model() which internally
>     gets the string from the skeleton? Internally in the code we do get the
>     skeleton multiple times, but usually always within the interface
>     implementation where that skeleton is a property. Cross-interface
>     skeleton retrievals, or skeleton retrievals from within the specific
>     object implementations are usually avoided, or at least that was the
>     intended purpose.
> Thanks. I've revised the patches to use the mm_iface_modem_get_model
> approach. Do mm_gdbus_* actually call through DBus to read a property?

No, not in the server side.

The mm_gdbus_* calls, if done in the server side, they just read
properties from the interface skeleton objects.

The mm_gdbus_* calls, if done in the client side, they read properties
from the interface proxy objects, and these properties get automatically
updated via DBus when they change.


More information about the ModemManager-devel mailing list