[PATCH 0/2] MBIM: Report 3GPP cause codes on errors

[Bjørn Mork]

Aleksander Morgado <aleksander at lanedo.com> writes:
> On 19/12/13 12:55, Bjørn Mork wrote:
>> ModemManager[1592]: <debug> [1387444281.867866] [mm-iface-modem-simple.c:221] connect_bearer_ready(): Couldn't connect bearer: 'Failure'
>> 
>> 
>> and that generic 'Failure' was the only thing reported back.  So I had to
>> manually decode the MBIM message myself to get the raw 3GPP cause code
>> (those knowing there MBIM well enough will of course immeditately see the
>> 1C:00:00:00 there are the end), and then go look it up.  This doesn't
>> look right to me.  The end users should not have to do such things.  So I
>> started digging into the code to find out why MM doesn't use the NwError
>> field.  Turns out MM won't parse the reply at all unless the status is
>> success.  Which doesn't seem right.
>
> You're right with patch 2/2, we can gather nw_error when the result in
> the response is Failure. But not sure if we need patch 1/2; as the error
> is propagated to upper layers, which will be the ones reporting it in
> the log.

I agree.  It was my first attempt at getting these messages before I
noticed the failure to parse.  So it's probably not necessary.


Bjørn