[MM][PATCH] altair-lte: add support for 3GPP Vendor PCO info

[Aleksander Morgado]

On 11/07/13 04:18, ori inbar wrote:
> 
>     We should have unit tests for all these parsers, so let's add them. See
> 
>     for example this one:
> 
> 
>     http://cgit.freedesktop.org/ModemManager/ModemManager/commit/?h=aleksander/huawei-ndisstatqry&id=af7564cf82b380c814ce14ca80faacd62e20585a
> 
> 
>     That's a parser plus unit tests for a Huawei-specific thing.
> 
> 
>     Please do the same here; move this method to a pair of new
> 
>     "mm-modem-helpers-altair-lte.[ch]" files, rename it as
> 
>     "mm_altair_lte_parse_vendor_pco_info", and then add unit tests for it
> 
>     with different example replies that we get for the PCO info. You'll
> 
>     probably need to copy some bits from the Makefile.am in that patch, as
>     that is not yet pushed to git master.
> 
> 
> i will look into it - i hope for now u can accept it without this addition.

I really prefer to have them in along with the main change if
possible... but I'll leave it to you. Please, don't forget it.

-- 
Aleksander