[PATCH] altair-lte: set serial port send delay to 0

Dan Williams dcbw at redhat.com
Sun Jul 14 19:04:10 PDT 2013


On Sun, 2013-07-14 at 17:24 -0700, Ben Chan wrote:
> With a non-zero send delay, the communication over the ttyACM port of
> the modem is not very stable when USB auto-suspend is enabled for the
> modem. The send delay is not necessary and thus removed by this patch.

Pushed, thanks!

Dan

> Ori Inbar <ori.inbar at altair-semi.com> reported the issue and suggested
> this fix.
> ---
>  plugins/altair/mm-broadband-modem-altair-lte.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/plugins/altair/mm-broadband-modem-altair-lte.c b/plugins/altair/mm-broadband-modem-altair-lte.c
> index e524103..3c5ef6c 100644
> --- a/plugins/altair/mm-broadband-modem-altair-lte.c
> +++ b/plugins/altair/mm-broadband-modem-altair-lte.c
> @@ -913,8 +913,11 @@ setup_ports (MMBroadbandModem *self)
>      MM_BROADBAND_MODEM_CLASS (mm_broadband_modem_altair_lte_parent_class)->setup_ports (self);
>  
>      primary = mm_base_modem_peek_port_primary (MM_BASE_MODEM (self));
> +    if (!primary)
> +        return;
>  
> -    g_object_set (mm_base_modem_peek_port_primary (MM_BASE_MODEM (self)),
> +    g_object_set (primary,
> +                  MM_SERIAL_PORT_SEND_DELAY, (guint64) 0,
>                    MM_AT_SERIAL_PORT_SEND_LF, TRUE,
>                    MM_AT_SERIAL_PORT_INIT_SEQUENCE, primary_init_sequence,
>                    NULL);




More information about the ModemManager-devel mailing list