[PATCH] altair: Mark SIM provisioned in load_subscription_state
Prathmesh Prabhu
pprabhu at chromium.org
Thu Oct 10 13:11:15 PDT 2013
An unknown --> home (roaming) registration state change is not visible to the
plugin until mm_iface_modem_3gpp_reload_current_registration_info completes.
This causes the subscription state check during registration to miss the fact
that registration was successful.
load_subscription_state is intended to check subscription state
post-registration. As an initial implementation, mark the SIM provisioned in
absence of more information post-registration.
---
plugins/altair/mm-broadband-modem-altair-lte.c | 44 ++++++++++++++++++++++++++
1 file changed, 44 insertions(+)
diff --git a/plugins/altair/mm-broadband-modem-altair-lte.c b/plugins/altair/mm-broadband-modem-altair-lte.c
index 64d4c51..6d0c606 100644
--- a/plugins/altair/mm-broadband-modem-altair-lte.c
+++ b/plugins/altair/mm-broadband-modem-altair-lte.c
@@ -1025,6 +1025,48 @@ modem_3gpp_load_operator_name (MMIfaceModem3gpp *self,
}
/*****************************************************************************/
+/* Subscription State Loading (3GPP interface) */
+
+static MMModem3gppSubscriptionState
+modem_3gpp_load_subscription_state_finish (MMIfaceModem3gpp *self,
+ GAsyncResult *res,
+ GError **error)
+{
+ if (g_simple_async_result_propagate_error (G_SIMPLE_ASYNC_RESULT (res), error))
+ return MM_MODEM_3GPP_SUBSCRIPTION_STATE_UNKNOWN;
+ return (MMModem3gppSubscriptionState) GPOINTER_TO_UINT (
+ g_simple_async_result_get_op_res_gpointer (G_SIMPLE_ASYNC_RESULT (res)));
+}
+
+static void
+modem_3gpp_load_subscription_state (MMIfaceModem3gpp *self,
+ GAsyncReadyCallback callback,
+ gpointer user_data)
+{
+ GSimpleAsyncResult *result;
+
+ result = g_simple_async_result_new (G_OBJECT (self),
+ callback,
+ user_data,
+ modem_3gpp_load_subscription_state);
+
+ /* Reloading subscription state only occurs on a successfully registered
+ * modem. (Although the 3GPP interface does not reflect this until after
+ * loading operator information completes.)
+ * We should set the subscription state to provisioned here, unless further information from PCO
+ * says otherwise.
+ * TODO: Use PCO value to check for subscription state post-registration.
+ */
+ mm_dbg ("Load subscription state: Marking the SIM as provisioned.");
+ g_simple_async_result_set_op_res_gpointer (
+ result,
+ GUINT_TO_POINTER (MM_MODEM_3GPP_SUBSCRIPTION_STATE_PROVISIONED),
+ NULL);
+
+ g_simple_async_result_complete_in_idle (result);
+}
+
+/*****************************************************************************/
/* Generic ports open/close context */
static const gchar *primary_init_sequence[] = {
@@ -1146,6 +1188,8 @@ iface_modem_3gpp_init (MMIfaceModem3gpp *iface)
iface->register_in_network_finish = modem_3gpp_register_in_network_finish;
iface->run_registration_checks = modem_3gpp_run_registration_checks;
iface->run_registration_checks_finish = modem_3gpp_run_registration_checks_finish;
+ iface->load_subscription_state = modem_3gpp_load_subscription_state;
+ iface->load_subscription_state_finish = modem_3gpp_load_subscription_state_finish;
/* Scanning is not currently supported */
iface->scan_networks = NULL;
--
1.8.4
More information about the ModemManager-devel
mailing list