[PATCH] broadband-modem-mbim: update to use mbim_message_device_service_subscribe_list

Dan Williams dcbw at redhat.com
Wed Feb 19 16:52:50 PST 2014


On Tue, 2014-02-18 at 12:43 -0800, Ben Chan wrote:
> libmbim renames 'MBIM_CID_DEVICE_SERVICE_SUBSCRIBER_LIST' to
> 'MBIM_CID_DEVICE_SERVICE_SUBSCRIBE_LIST' to be consistent with the MBIM
> specification. This patch updates MMBroadbandModemMbim accordingly.
> ---
> This patch needs to be coordinated with the corresponding libmbim change.

Pushed and bumped the libmbim requirement in configure.ac to >= 1.7.

Dan

> Ben
> 
> 
>  src/mm-broadband-modem-mbim.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/src/mm-broadband-modem-mbim.c b/src/mm-broadband-modem-mbim.c
> index 714cb70..f1f786c 100644
> --- a/src/mm-broadband-modem-mbim.c
> +++ b/src/mm-broadband-modem-mbim.c
> @@ -1897,9 +1897,9 @@ common_enable_disable_unsolicited_events_finish (MMBroadbandModemMbim *self,
>  }
>  
>  static void
> -subscriber_list_set_ready_cb (MbimDevice *device,
> -                              GAsyncResult *res,
> -                              GSimpleAsyncResult *simple)
> +subscribe_list_set_ready_cb (MbimDevice *device,
> +                             GAsyncResult *res,
> +                             GSimpleAsyncResult *simple)
>  {
>      MbimMessage *response;
>      GError *error = NULL;
> @@ -1970,7 +1970,7 @@ common_enable_disable_unsolicited_events (MMBroadbandModemMbim *self,
>          n_entries++;
>      }
>  
> -    request = (mbim_message_device_service_subscriber_list_set_new (
> +    request = (mbim_message_device_service_subscribe_list_set_new (
>                     n_entries,
>                     (const MbimEventEntry *const *)entries,
>                     NULL));
> @@ -1978,7 +1978,7 @@ common_enable_disable_unsolicited_events (MMBroadbandModemMbim *self,
>                           request,
>                           10,
>                           NULL,
> -                         (GAsyncReadyCallback)subscriber_list_set_ready_cb,
> +                         (GAsyncReadyCallback)subscribe_list_set_ready_cb,
>                           result);
>      mbim_message_unref (request);
>      mbim_event_entry_array_free (entries);




More information about the ModemManager-devel mailing list