[review] dcbw/icera-fixes: random Icera fixes and addition of IPv6 support

Aleksander Morgado aleksander at aleksander.es
Thu Feb 20 01:37:19 PST 2014

On Tue, Feb 18, 2014 at 8:34 PM, Dan Williams <dcbw at redhat.com> wrote:
> I dusted off WWAN IPv6 in NetworkManager again and found some
> deficiencies in the Icera IPv6 support (eg, there was none).  Given that
> the only non-Qualcomm modems I have that reliably support IPv6 are Icera
> based, time to use it.
> Note that the 21M only returns an IPv6 link-local address and a DNS
> server, and the client should use normal IPv6 neighbor discovery
> procedures (eg, RS and RA) to determine the IPv6 prefix and router.
> There are also a couple other fixes to the Sierra Icera code based on
> testing the Icera stuff.
> Tested with Samsung Y3300, Sierra USB305, Nokia 21M, and ZTE/Vodafone
> K3805-Z.  Please review!

+typedef struct {
+    MMBearerIpConfig *ipv4;
+    MMBearerIpConfig *ipv6;
+} IpConfigs;

Instead of building a custom "IpConfigs" struct, better use the
"MMBearerConnectResult" type defined in mm-bearer.[h|c]; which serves
exactly the same purpose.

Other than that, looks good to me :)


More information about the ModemManager-devel mailing list