[PATCH] broadband-modem-mbim: propagate error if MBIM_CID_VISIBLE_PROVIDERS query fails

[Ben Chan]

On Fri, Feb 28, 2014 at 12:19 AM, Aleksander Morgado <
aleksander at aleksander.es> wrote:

>
> This is actually wrong.
>
> This is the _finish() method, and the target of the method is to get the
> result or error from the GAsyncResult and propagate it to the output
> GError.
>
> If the GAsyncResult had an error, it is propagated to the output GError
> at the beginning of the method:
>     if (g_simple_async_result_propagate_error (G_SIMPLE_ASYNC_RESULT
> (res), error))
>         return NULL;
>
> If the GAsyncResult didn't have an error, we keep on building the info
> list to return. If building the list fails, we *don't* need to propagate
> that GError to the GAsyncResult, we just need to make sure that the
> output GError gets it, and that is already done implicitly (both
> mbim_message_command_done_get_result() and
> mbim_message_visible_providers_response_parse() use directly the output
> GError to set the possible error).
>
>
Oops...sorry, I must have a blank moment today :p  I was scanning for
missing checks on command-done messages and came across this function...
and I didn't recognize my code
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/modemmanager-devel/attachments/20140228/4d6c3549/attachment.html>