[PATCH 3/3] altair-lte: remove unnecessary MM_BASE_MODEM() casts

Aleksander Morgado aleksander at aleksander.es
Fri Jan 3 03:31:39 PST 2014


On 03/01/14 01:00, Ben Chan wrote:
> ---
>  plugins/altair/mm-broadband-bearer-altair-lte.c | 12 +++---------
>  plugins/altair/mm-broadband-modem-altair-lte.c  |  4 ++--
>  2 files changed, 5 insertions(+), 11 deletions(-)
> 

Pushed, thanks.

> diff --git a/plugins/altair/mm-broadband-bearer-altair-lte.c b/plugins/altair/mm-broadband-bearer-altair-lte.c
> index f08517b..d3ef1b8 100644
> --- a/plugins/altair/mm-broadband-bearer-altair-lte.c
> +++ b/plugins/altair/mm-broadband-bearer-altair-lte.c
> @@ -115,9 +115,7 @@ connect_3gpp_connect_ready (MMBaseModem *modem,
>      GError *error = NULL;
>      MMBearerIpConfig *config;
>  
> -    result = mm_base_modem_at_command_finish (MM_BASE_MODEM (modem),
> -                                              res,
> -                                              &error);
> +    result = mm_base_modem_at_command_finish (modem, res, &error);
>      if (!result) {
>          mm_warn ("connect failed: %s", error->message);
>          g_simple_async_result_take_error (ctx->result, error);
> @@ -152,9 +150,7 @@ connect_3gpp_apnsettings_ready (MMBaseModem *modem,
>      const gchar *result;
>      GError *error = NULL;
>  
> -    result = mm_base_modem_at_command_finish (MM_BASE_MODEM (modem),
> -                                              res,
> -                                              &error);
> +    result = mm_base_modem_at_command_finish (modem, res, &error);
>      if (!result) {
>          mm_warn ("setting APN failed: %s", error->message);
>          g_simple_async_result_take_error (ctx->result, error);
> @@ -304,9 +300,7 @@ disconnect_3gpp_check_status (MMBaseModem *modem,
>      const gchar *result;
>      GError *error = NULL;
>  
> -    result = mm_base_modem_at_command_finish (MM_BASE_MODEM (modem),
> -                                              res,
> -                                              &error);
> +    result = mm_base_modem_at_command_finish (modem, res, &error);
>      if (!result) {
>          mm_warn ("Disconnect failed: %s", error->message);
>          g_simple_async_result_take_error (ctx->result, error);
> diff --git a/plugins/altair/mm-broadband-modem-altair-lte.c b/plugins/altair/mm-broadband-modem-altair-lte.c
> index 4e2349e..9d3373c 100644
> --- a/plugins/altair/mm-broadband-modem-altair-lte.c
> +++ b/plugins/altair/mm-broadband-modem-altair-lte.c
> @@ -172,7 +172,7 @@ load_unlock_retries_ready (MMBaseModem *self,
>      GError *error = NULL;
>      gint pin1, puk1, pin2, puk2;
>  
> -    response = mm_base_modem_at_command_finish (MM_BASE_MODEM (self), res, &error);
> +    response = mm_base_modem_at_command_finish (self, res, &error);
>      if (!response) {
>          mm_dbg ("Couldn't query unlock retries: '%s'", error->message);
>          g_simple_async_result_take_error (operation_result, error);
> @@ -668,7 +668,7 @@ altair_deregister_ready (MMBaseModem *self,
>  
>      /* Register */
>      mm_base_modem_at_command (
> -        MM_BASE_MODEM (self),
> +        self,
>          "%CMATT=1",
>          10,
>          FALSE, /* allow_cached */
> 


-- 
Aleksander Morgado
http://aleksander.es


More information about the ModemManager-devel mailing list