[PATCH 1/3] altair-lte: reference the secondary port in DetailedConnectContext

[Ben Chan]

On Fri, Jan 3, 2014 at 3:26 AM, Aleksander Morgado <aleksander at aleksander.es
> wrote:

> On 03/01/14 01:00, Ben Chan wrote:
> > ---
> >  plugins/altair/mm-broadband-bearer-altair-lte.c | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
>
> What's the purpose of keeping a reference to the secondary port around
> if it is not going to be used during the connection sequence?
>
>
IIUC, the connection sequence uses mm_base_modem_at_command, which could
potentially pick up the secondary port, if one exists. The existing code
works but this patch makes the code more future-proof (and more symmetric
to the disconnection sequence, which also references the secondary port).
Alternatively, we could explicitly use the primary port, or add g_assert
(secondary == NULL) if the modem never has a secondary port.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/modemmanager-devel/attachments/20140103/a83ea20d/attachment.html>