[review] dcbw/ipv6-fixes: fix IPv6 support in core and plugins

Dan Williams dcbw at redhat.com
Thu Jun 12 13:08:10 PDT 2014

On Wed, 2014-06-11 at 14:38 +0200, Bjørn Mork wrote:
> Dan Williams <dcbw at redhat.com> writes:
> > Please review and test!
> >
> > Big changes in this branch (which we can change if we want to!) are that
> > by default, QMI, Ericsson/MBM, and Icera devices now read and send
> > static IP configuration in-addition-to/instead of DHCP, if we have those
> > details.  This is done for both IPv4 and IPv6.
> >
> > For QMI, static configuration is always used, because we can always read
> > the IP addresses and DNS servers from the firmware.
> >
> > For MBM, if the firmware supports E2IPCFG we use that information,
> > otherwise we fall back to DHCP/auto.


> ModemManager[24901]: <debug> [1402489940.320635] [mm-bearer-qmi.c:475] get_current_settings_ready():  IP Family: failed (Field 'IP Family' was not found in the message)
> ModemManager[24901]: <debug> [1402489940.321067] [mm-bearer-qmi.c:492] get_current_settings_ready():    Domains: failed (Field 'Domain Name List' was not found in the message)
> ModemManager[24901]: <debug> [1402489940.321410] [mm-port.c:93] mm_port_set_connected(): (wwan1): port now connected
> ModemManager[24901]: <debug> [1402489940.321869] [mm-bearer.c:489] connect_ready(): Connected bearer '/org/freedesktop/ModemManager1/Bearer/7'
> ModemManager[24901]: <info>  [1402489940.322334] [mm-iface-modem.c:1392] __iface_modem_update_state_internal(): Modem /org/freedesktop/ModemManager1/Modem/4: state changed (connecting -> connected)
> ModemManager[24901]: <info>  [1402489940.323778] [mm-iface-modem-simple.c:602] connection_step(): Simple connect state (8/8): All done

> This modem does not support IPv6, so I guess the 'IP Family' TLV is just
> left out as redundant?  In any case: All the TLVs are family specific so
> it shouldn't really be a problem parsing them without the family TLV.

Pushed a fixup to just assume IPv4 if no family TLV is given.


More information about the ModemManager-devel mailing list