[review] dcbw/ipv6-fixes: fix IPv6 support in core and plugins

[Bjørn Mork]

Aleksander Morgado <aleksander at aleksander.es> writes:

> On Fri, Jun 13, 2014 at 2:37 PM, Bjørn Mork <bjorn at mork.no> wrote:
>>
>> (ModemManager:27662): GLib-WARNING **: GError set over the top of a previous GError or uninitialized memory.
>> This indicates a bug in someone's code. You must ensure an error is NULL before it's set.
>> The overwriting error message was: Field 'MTU' was not found in the message
>> ModemManager[27662]: <debug> [1402662737.774325] [mm-bearer-qmi.c:470] get_current_settings_ready():        MTU: failed (Field 'IP Family' was not found in the message)
>> ModemManager[27662]: <debug> [1402662737.774576] [mm-bearer-qmi.c:492] get_current_settings_ready():    Domains: failed (Field 'Domain Name List' was not found in the message)
>> ModemManager[27662]: <debug> [1402662737.775143] [mm-port.c:93] mm_port_set_connected(): (wwan1): port now connected
>> ModemManager[27662]: <debug> [1402662737.775885] [mm-bearer.c:489] connect_ready(): Connected bearer '/org/freedesktop/ModemManager1/Bearer/1'
>> ModemManager[27662]: <info>  [1402662737.776676] [mm-iface-modem.c:1392] __iface_modem_update_state_internal(): Modem /org/freedesktop/ModemManager1/Modem/1: state changed (connecting -> connected)
>> ModemManager[27662]: <info>  [1402662737.779366] [mm-iface-modem-simple.c:602] connection_step(): Simple connect state (8/8): All done
>
>
> Pushed a fixup commit to handle that error case in the branch.

Great! Looks good now:


ModemManager[18954]: [/dev/cdc-wdm1] Received message...
>>>>>> RAW:
>>>>>>   length = 91
>>>>>>   data   = 01:5A:00:80:01:01:02:02:00:2D:00:4E:00:02:04:00:00:00:00:00:1E:04:00:5A:02:42:2E:15:04:00:04:70:D5:C1:16:04:00:C6:0F:43:82:20:04:00:59:02:42:2E:21:04:00:FC:FF:FF:FF:17:21:00:04:80:21:00:00:C0:21:00:00:00:00:00:00:00:00:00:00:02:DC:05:00:00:04:07:03:00:00:00:00:01:00:00:00
ModemManager[18954]: [/dev/cdc-wdm1] Received message (translated)...
>>>>>> QMUX:
>>>>>>   length  = 90
>>>>>>   flags   = 0x80
>>>>>>   service = "wds"
>>>>>>   client  = 1
>>>>>> QMI:
>>>>>>   flags       = "response"
>>>>>>   transaction = 2
>>>>>>   tlv_length  = 78
>>>>>>   message     = "Get Current Settings" (0x002D)
>>>>>> TLV:
>>>>>>   type       = "Result" (0x02)
>>>>>>   length     = 4
>>>>>>   value      = 00:00:00:00
>>>>>>   translated = SUCCESS
>>>>>> TLV:
>>>>>>   type       = "IPv4 Address" (0x1e)
>>>>>>   length     = 4
>>>>>>   value      = 5A:02:42:2E
>>>>>>   translated = 776077914
>>>>>> TLV:
>>>>>>   type       = "Primary IPv4 DNS Address" (0x15)
>>>>>>   length     = 4
>>>>>>   value      = 04:70:D5:C1
>>>>>>   translated = 3251990532
>>>>>> TLV:
>>>>>>   type       = "Secondary IPv4 DNS Address" (0x16)
>>>>>>   length     = 4
>>>>>>   value      = C6:0F:43:82
>>>>>>   translated = 2185433030
>>>>>> TLV:
>>>>>>   type       = "IPv4 Gateway Address" (0x20)
>>>>>>   length     = 4
>>>>>>   value      = 59:02:42:2E
>>>>>>   translated = 776077913
>>>>>> TLV:
>>>>>>   type       = "IPv4 Gateway Subnet Mask" (0x21)
>>>>>>   length     = 4
>>>>>>   value      = FC:FF:FF:FF
>>>>>>   translated = 4294967292
>>>>>> TLV:
>>>>>>   type   = 0x17
>>>>>>   length = 33
>>>>>>   value  = 04:80:21:00:00:C0:21:00:00:00:00:00:00:00:00:00:00:02:DC:05:00:00:04:07:03:00:00:00:00:01:00:00:00
ModemManager[18954]: <debug> [1402668213.422031] [mm-bearer-qmi.c:461] get_current_settings_ready():  IP Family: failed (Field 'IP Family' was not found in the message); assuming IPv4
ModemManager[18954]: <debug> [1402668213.422222] [mm-bearer-qmi.c:467] get_current_settings_ready():  IP Family: IPv4
ModemManager[18954]: <debug> [1402668213.422411] [mm-bearer-qmi.c:470] get_current_settings_ready():        MTU: failed (Field 'MTU' was not found in the message)
ModemManager[18954]: <debug> [1402668213.422607] [mm-bearer-qmi.c:291] get_ipv4_config(): QMI IPv4 Settings:
ModemManager[18954]: <debug> [1402668213.422795] [mm-bearer-qmi.c:300] get_ipv4_config():     Address: 46.66.2.90/30
ModemManager[18954]: <debug> [1402668213.422976] [mm-bearer-qmi.c:306] get_ipv4_config():     Gateway: 46.66.2.89
ModemManager[18954]: <debug> [1402668213.423158] [mm-bearer-qmi.c:316] get_ipv4_config():     DNS #1: 193.213.112.4
ModemManager[18954]: <debug> [1402668213.423338] [mm-bearer-qmi.c:326] get_ipv4_config():     DNS #2: 130.67.15.198
ModemManager[18954]: <debug> [1402668213.423522] [mm-bearer-qmi.c:492] get_current_settings_ready():    Domains: failed (Field 'Domain Name List' was not found in the message)
ModemManager[18954]: <debug> [1402668213.423715] [mm-port.c:93] mm_port_set_connected(): (wwan1): port now connected
ModemManager[18954]: <debug> [1402668213.423948] [mm-bearer.c:489] connect_ready(): Connected bearer '/org/freedesktop/ModemManager1/Bearer/1'
ModemManager[18954]: <info>  [1402668213.424293] [mm-iface-modem.c:1392] __iface_modem_update_state_internal(): Modem /org/freedesktop/ModemManager1/Modem/1: state changed (connecting -> connected)
ModemManager[18954]: <info>  [1402668213.426249] [mm-iface-modem-simple.c:602] connection_step(): Simple connect state (8/8): All done



Bjørn