[review] dcbw/ipv6-fixes: fix IPv6 support in core and plugins

[Aleksander Morgado]

On Fri, Jun 13, 2014 at 6:15 PM, Dan Williams <dcbw at redhat.com> wrote:
>> > >
>> > > (ModemManager:27662): GLib-WARNING **: GError set over the top of a previous GError or uninitialized memory.
>> > > This indicates a bug in someone's code. You must ensure an error is NULL before it's set.
>> > > The overwriting error message was: Field 'MTU' was not found in the message
>> > > ModemManager[27662]: <debug> [1402662737.774325] [mm-bearer-qmi.c:470] get_current_settings_ready():        MTU: failed (Field 'IP Family' was not found in the message)
>> > > ModemManager[27662]: <debug> [1402662737.774576] [mm-bearer-qmi.c:492] get_current_settings_ready():    Domains: failed (Field 'Domain Name List' was not found in the message)
>> > > ModemManager[27662]: <debug> [1402662737.775143] [mm-port.c:93] mm_port_set_connected(): (wwan1): port now connected
>> > > ModemManager[27662]: <debug> [1402662737.775885] [mm-bearer.c:489] connect_ready(): Connected bearer '/org/freedesktop/ModemManager1/Bearer/1'
>> > > ModemManager[27662]: <info>  [1402662737.776676] [mm-iface-modem.c:1392] __iface_modem_update_state_internal(): Modem /org/freedesktop/ModemManager1/Modem/1: state changed (connecting -> connected)
>> > > ModemManager[27662]: <info>  [1402662737.779366] [mm-iface-modem-simple.c:602] connection_step(): Simple connect state (8/8): All done
>> >
>> >
>> > Pushed a fixup commit to handle that error case in the branch.
>>
>> That's what I get for not actually testing it well enough...
>
> So final verdict is "go"?


+1 from me.

-- 
Aleksander
https://aleksander.es