[PATCH v2] broadband-modem-mbim: convert additional GMM error codes to mm errors.

[Dan Williams]

On Mon, 2014-06-16 at 14:54 -0700, Prathmesh Prabhu Chromium wrote:
> Hi,
> 
> This patch can only be pushed after the corresponding libmbim patch:
> http://lists.freedesktop.org/archives/modemmanager-devel/2014-June/001282.html

It also conflicts with a patch Ben sent last Monday; which already added
the NOT_SUBSCRIBED error.  But yours does add the MISSING_OR_UNKNOWN_APN
error which should definitely be useful and does require the libmbim
patch.

Dan

> Thanks,
> Prathmesh
> 
> 
> 
> On Mon, Jun 16, 2014 at 2:52 PM, <pprabhu at chromium.org> wrote:
> 
> > From: Prathmesh Prabhu <pprabhu at chromium.org>
> >
> > diff --git a/src/mm-modem-helpers-mbim.c b/src/mm-modem-helpers-mbim.c
> > index 8060ace..900e1bb 100644
> > --- a/src/mm-modem-helpers-mbim.c
> > +++ b/src/mm-modem-helpers-mbim.c
> > @@ -227,6 +227,15 @@ mm_mobile_equipment_error_from_mbim_nw_error
> > (MbimNwError nw_error)
> >          return g_error_new (MM_MOBILE_EQUIPMENT_ERROR,
> >                              MM_MOBILE_EQUIPMENT_ERROR_GPRS_CONGESTION,
> >                              "Congestion");
> > +    case MBIM_NW_ERROR_MISSING_OR_UNKNOWN_APN:
> > +        return g_error_new (MM_MOBILE_EQUIPMENT_ERROR,
> > +
> >  MM_MOBILE_EQUIPMENT_ERROR_GPRS_MISSING_OR_UNKNOWN_APN,
> > +                            "Missing or unknown APN");
> > +    case MBIM_NW_ERROR_REQUESTED_SERVICE_OPTION_NOT_SUBSCRIBED:
> > +        return g_error_new (MM_MOBILE_EQUIPMENT_ERROR,
> > +
> >  MM_MOBILE_EQUIPMENT_ERROR_GPRS_SERVICE_OPTION_NOT_SUBSCRIBED,
> > +                            "Requested service option not subscribed");
> > +
> >      default:
> >          return g_error_new (MM_MOBILE_EQUIPMENT_ERROR,
> >                              MM_MOBILE_EQUIPMENT_ERROR_GPRS_UNKNOWN,
> > --
> > 2.0.0.526.g5318336
> >
> >
> _______________________________________________
> ModemManager-devel mailing list
> ModemManager-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/modemmanager-devel