[PATCH] icera: fix 'sometimes-uninitialized' variable issues
Dan Williams
dcbw at redhat.com
Wed Jun 18 06:36:02 PDT 2014
On Tue, 2014-06-17 at 23:56 -0700, Ben Chan wrote:
> ---
> plugins/icera/mm-broadband-bearer-icera.c | 2 +-
> plugins/icera/mm-modem-helpers-icera.c | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
Pushed, thanks!
Dan
> diff --git a/plugins/icera/mm-broadband-bearer-icera.c b/plugins/icera/mm-broadband-bearer-icera.c
> index 347f373..ed4f4a4 100644
> --- a/plugins/icera/mm-broadband-bearer-icera.c
> +++ b/plugins/icera/mm-broadband-bearer-icera.c
> @@ -218,7 +218,7 @@ get_ip_config_3gpp (MMBroadbandBearer *self,
> /* Otherwise, DHCP */
> if (ctx->self->priv->default_ip_method == MM_BEARER_IP_METHOD_DHCP) {
> MMBearerConnectResult *connect_result;
> - MMBearerIpConfig *ipv4_config, *ipv6_config;
> + MMBearerIpConfig *ipv4_config = NULL, *ipv6_config = NULL;
>
> if (ip_family & MM_BEARER_IP_FAMILY_IPV4 || ip_family & MM_BEARER_IP_FAMILY_IPV4V6) {
> ipv4_config = mm_bearer_ip_config_new ();
> diff --git a/plugins/icera/mm-modem-helpers-icera.c b/plugins/icera/mm-modem-helpers-icera.c
> index fd3e4fc..f9aa612 100644
> --- a/plugins/icera/mm-modem-helpers-icera.c
> +++ b/plugins/icera/mm-modem-helpers-icera.c
> @@ -203,7 +203,7 @@ mm_icera_parse_ipdpaddr_response (const gchar *response,
> MMBearerIpConfig *ip4_config = NULL;
> MMBearerIpConfig *ip6_config = NULL;
> GError *local = NULL;
> - gboolean success;
> + gboolean success = FALSE;
> char **items;
> guint num_items, i, first_free;
> gint num;
> @@ -258,7 +258,7 @@ mm_icera_parse_ipdpaddr_response (const gchar *response,
> g_propagate_error (error, local);
> goto out;
> }
> -
> +
> ip6_config = parse_ipdpaddr_v6 ((const gchar **) items, num_items, &local);
> if (local) {
> g_propagate_error (error, local);
More information about the ModemManager-devel
mailing list