pdp_type=IPV4 not handled (patch)

[Oskar Enoksson]

My modem reports a PDP type "IPV4" which wasn't handled in
mm-modem-helpers.c. The obvious fix was to return MM_BEARER_IP_FAMILY_IPV4.

Actually the modem also reports pdp_type "PPP". I'm not sure what to do
with that ...

*** ModemManager-1.4.0.org/src/mm-modem-helpers.c       2014-08-20
00:17:16.000000000 +0200
--- ModemManager-1.4.0/src/mm-modem-helpers.c   2014-10-27
22:04:57.856216517 +0100
***************
*** 1899,1904 ****
--- 1899,1906 ----
  {
      if (g_str_equal (pdp_type, "IP"))
          return MM_BEARER_IP_FAMILY_IPV4;
+     if (g_str_equal (pdp_type, "IPV4"))
+         return MM_BEARER_IP_FAMILY_IPV4;
      if (g_str_equal (pdp_type, "IPV6"))
          return MM_BEARER_IP_FAMILY_IPV6;
      if (g_str_equal (pdp_type, "IPV4V6"))


On 10/28/2014 09:27 AM, Aleksander Morgado wrote:
> Hey Oskar,
> 
> On Tue, Oct 28, 2014 at 12:44 AM, Oskar Enoksson <enok at lysator.liu.se> wrote:
>> I'm making some progress.
>>
>> However, I did some necessary improvements in the 1.4.0 main sourcecode
>> in order to make modem command responses parsing work correctly (this
>> modem inserted whitespace in places that weren't handled by current
>> scanf pattern. It was just a few very easy fixes) . How can I commit
>> those fixes? Can I commit using git to somewhere?
>>
> 
> The best approach would be to send patches directly to this mailing
> list (e.g. with git send-email), so that maintainers can review and
> apply them.
> 
> Cheers!
>