[PATCH] Handle "IPV4" pdp type response

Oskar Enoksson enok at lysator.liu.se
Wed Oct 29 15:50:12 PDT 2014


I think you accidently lost a "V" in "IPV4" in your manual copy/paste of
the patch:

>> +    if (g_str_equal (pdp_type, "IP4"))
>> +        return MM_BEARER_IP_FAMILY_IPV4;

should be

>> +    if (g_str_equal (pdp_type, "IPV4"))
>> +        return MM_BEARER_IP_FAMILY_IPV4;


On 10/29/2014 11:16 PM, Aleksander Morgado wrote:
> On 29/10/14 22:08, Oskar Enoksson wrote:
>>
>> My modem (Samsung GI B3740) responded "IPV4" to "CGDCONT=?". This was
>> not handled in mm-modem-helpers.c. The obvious fix was to return
>> MM_BEARER_IP_FAMILY_IPV4.
>> ---
> 
> Pushed to git master and mm-1-4, but I had to manually rewrite the patch.
> 
> For some reason your emails get base64 encoded and a simple "git am
> email.txt" doesn't work... :/
> 
> 
>>  src/mm-modem-helpers.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/src/mm-modem-helpers.c b/src/mm-modem-helpers.c
>> index e4967d7..64b4928 100644
>> --- a/src/mm-modem-helpers.c
>> +++ b/src/mm-modem-helpers.c
>> @@ -1899,6 +1899,8 @@ mm_3gpp_get_ip_family_from_pdp_type (const gchar
>> *pdp_type)
>>  {
>>      if (g_str_equal (pdp_type, "IP"))
>>          return MM_BEARER_IP_FAMILY_IPV4;
>> +    if (g_str_equal (pdp_type, "IPV4"))
>> +        return MM_BEARER_IP_FAMILY_IPV4;
>>      if (g_str_equal (pdp_type, "IPV6"))
>>          return MM_BEARER_IP_FAMILY_IPV6;
>>      if (g_str_equal (pdp_type, "IPV4V6"))
>>
> 
> 


More information about the ModemManager-devel mailing list