[PATCH] location: support updating the GPS refresh time

[Aleksander Morgado]

On Mon, Dec 14, 2015 at 8:57 PM, Dan Williams <dcbw at redhat.com> wrote:
>> Looks mostly good.  Though I did get an error attempting to disable a
>> my QMI-based E397 while location gathering was active, which probably
>> wasn't caused by this specific patch:
>>
>> ModemManager[28430]: <debug> [1450122321.042945] [mm-broadband-modem
>> -qmi.c:8470] location_event_report_indication_cb(): [NMEA]
>> $GPGSA,A,2,<stuff>
>>
>> ModemManager[28430]: <debug> [1450122321.348501] [mm-broadband
>> -modem.c:8637] iface_modem_location_disable_ready(): Couldn't disable
>> interface: 'Couldn't disable location 'gps-nmea' gathering: QMI
>> operation failed: Transaction timed out'
>> ModemManager[28430]: [/dev/cdc-wdm1] Received message...
>
> The NMEA indications are coming in at a pretty high rate on this modem,
> like every second or two.  Maybe we just need to wait longer to get the
> disable reply?

The default timeout for the "QMI PDS Set GPS Service State" message is
10s already (mm-broadband-modem-qmi.c, disable_location_gathering()).
Could you update those 10s to a much bigger value to see if we just
need to wait more? Also, is there no other PDS indication between your
stop request and the timeout?

My MC7304 here stops instantly, not even a second.


-- 
Aleksander
https://aleksander.es