State of ModemManager built with --with-newest-qmi-commands

[poma]

On 17.02.2015 08:53, Aleksander Morgado wrote:
> On Tue, Feb 17, 2015 at 7:21 AM, poma <pomidorabelisima at gmail.com> wrote:
>>>>>> So I would say, we need to identify which items would be needed with
>>>>>> the newer QMI commands and then integrate them in the standard
>>>>>> codebase, without needing to enable any configure option. What do you
>>>>>> think?
>>>>>
>>>>> I think its probably best to either disable the --with-newest-qmi-commands
>>>>> configure command or highlight in the doc/help for it that it is incomplete
>>>>> and broken and only for experimental use ;-)
>>>>>
>>>>
>>>> That's true. I'll actually remove the configure option but leave it
>>>> #ifdef-ed in the code. If anyone wants to enable that code, you'll
>>>> need to explicitly define some symbol in CFLAGS; like ./configure
>>>> "CFLAGS=-DNEWER_QMI_COMMANDS or something. That is less exposed than
>>>> the configure option and still useful if needed.
>>>
>>>
>>> Ok, removed configure switch in git master. Possibility to enable
>>> newest QMI commands is still available, but through:
>>>
>>>   ./configure CFLAGS="-DWITH_NEWEST_QMI_COMMANDS"
>>>
>>> Cheers,
>>>
>>
>>
>> Then why is this option still in use?
>>
>> http://pkgs.fedoraproject.org/cgit/ModemManager.git/tree/ModemManager.spec#n98
>>         --with-newest-qmi-commands \
> 
> Oh... Dan, can you remove that from the packaging?
> 

You know Morgado, too bad Williams the 1st is not a lecturer at the university, he knows well to explain things.