[RFC PATCH] port-qmi: automatically try to set 802.3 link layer protocol when opening

[Aleksander Morgado]

On Wed, Jun 10, 2015 at 12:57 PM, Dan Williams <dcbw at redhat.com> wrote:
>> We do this as early as possible, because it looks like the WDA operation
>> isn't allowed if the modem is in use.
>>
>> Also, this operation is only needed when the CTL Set Data Format command
>> is ignored by the modem, like the Netgear Aircard 341U.
>>
>> Last thing, we setup retries because the modem may ignore the requests for
>> some time.
>> ---
>>
>> Comments, anyone?
>
> Looks OK to me.  I haven't tested it though, but I assume you have with
> both WDA-supporting and non-WDA-supporting devices?

I tested it with the 341U to prove the switch; and with a couple other
non-WDA-capable devices. Note that this new logic is a fallback in
case the CTL command didn't work, which 99% of times it works, so I
don't see many complications. The big change here is the fact that the
modem exposure in DBus may get very delayed, as we don't expose it
until we know we can use it in 802.3 mode, but that is the way to go I
think. We don't want to let users try to connect QMI modems in raw-ip
mode.

-- 
Aleksander
https://aleksander.es