[PATCH] QMI modems ignore IMEI's with 0 prefix

[Dan Williams]

On Wed, 2015-05-27 at 13:01 +0200, Aleksander Morgado wrote:
> >>
> >> A small patch to allow ModemManager to handle the IMEI on my AT&T Beam (340u).
> >> It has the IMEI printed on the back:
> >>
> >>     013323000226606
> > 
> > Yes, that is definitely valid. '01' is http://www.ptcrb.com/
> > 
> > You might be more careful about double zeroes, but I cannot see any
> > reason why MM should refuse them.  There might even be valid use cases
> > where you'd want to run MM in a lab :)
> > 
> > For those interested in deciphering the two first IMEI digits:
> > http://en.wikipedia.org/wiki/Reporting_Body_Identifier
> > 
> > 
> 
> I truly cannot remember why I added that check in IMEI, ESN or MEID.
> 
> Dan, do you maybe recall a reason?

I don't recall, but it's been there since the beginning of QMI support
in:

81fe9f84ec05b9faa99f90191da12b6e986a330e
broadband-modem-qmi: load equipment ID using QMI

I originally thought it might have something to do with very early QMI
implementations being really really stupid (they were) but the earliest
Gobi 1K devices I have report a valid IMEI even with CDMA firmware.

My suggestion: patch is OK, if we *really* want to be paranoid we can
check for all '0' but that seems kinda pointless.

Dan