[PATCH] port-probe: make sure stored task pointer is set to NULL before completing

Aleksander Morgado aleksander at aleksander.es
Fri Apr 8 15:14:41 UTC 2016


On Fri, Apr 8, 2016 at 4:55 PM, Daniele Palmas <dnlplm at gmail.com> wrote:
> 2016-04-08 16:42 GMT+02:00 Aleksander Morgado <aleksander at aleksander.es>:
>> When we were completing tasks in idle, the logic was like this:
>>
>>  * Schedule task completion in idle
>>  * self->priv->task = NULL
>>  * (idle) Task completion callback called
>>
>> This meant that the self->priv->task was always set to NULL before the
>> completion callback was called, which is what we wanted as a new task may be
>> scheduled in the callback itself.
>>
>> Now, without completing in idle, we were wrongly doing:
>>
>>  * Task completion callback called
>>  * self->priv->task = NULL
>>
>> This commit fixes the logic by making sure self->priv->task = NULL before any
>> task completion.
>> ---
>>
>> Daniele, can you validate that this patch fixes your issue?
>>
>
> According to a quick test I did, it seems to fix the issue on LE910.

I'll get the patch merged to git master, and if your tests on Monday
go well, I'll release a new rc with this fix.

-- 
Aleksander
https://aleksander.es


More information about the ModemManager-devel mailing list