[PATCH] port-probe: make sure stored task pointer is set to NULL before completing

[Aleksander Morgado]

On Mon, Apr 11, 2016 at 4:56 PM, Carlo Lobrano <c.lobrano at gmail.com> wrote:
>
> it looks like the last commit introduced a some kind of problem. HE910
> initialization ends with error
>
>> Modem couldn't be initialized: couldn't load current capabilities: Failed
>> to determine modem capabilities
>
> Here's the pastebin link of the logs of this test,
>
>> http://pastebin.com/h5PkSb92
>
> while the following's the logs of a good run made with version
> 8a386218690aeff7e2c923a14f91da7bbc046ed2 (HEAD~1)
>
>> http://pastebin.com/0fqrW52k
>
> Apparently, the parser mm-broadband-modem.c:parse_caps_gcap isn't receiving
> the reply from the serial device (the last line is a debug log I added,
> which prints out the content of the "response" that the function is
> parsing).
>
> <debug> [1460381746.474901] [mm-port-serial-at.c:459] debug_log():
> (ttyACM0): --> 'AT+GCAP<CR>'
> <debug> [1460381746.521723] [mm-port-serial-at.c:459] debug_log():
> (ttyACM0): <-- '<CR><LF>'
> <debug> [1460381746.550323] [mm-port-serial-at.c:459] debug_log():
> (ttyACM0): <-- '+GCAP: +CGSM,+DS,+FCLASS,+MS,+ES<CR><LF><CR><LF>OK<CR><LF>'
> <debug> [1460381746.583914] [mm-broadband-modem.c:448] parse_caps_gcap():
> response is ''
>
> On LE910 SV V2 the behavior's the same.

Fixed it in git master now, sorry for that. It was actually
interesting to see what was the outcome of having missed some GTask
unrefs during probing... :)

-- 
Aleksander
https://aleksander.es