[PATCH 01/14] udev: remove ENV{DEVTYPE}!="usb_device" rules

Aleksander Morgado aleksander at aleksander.es
Mon Aug 1 16:50:19 UTC 2016


On Thu, Jul 28, 2016 at 5:22 PM, Dan Williams <dcbw at redhat.com> wrote:
>> > They're actually a subcase of SUBSYSTEM!="usb", which we apply just
>> > before.
>> Actually I thought this was to ensure we match the entire USB device,
>> not just a usb_interface.  Otherwise ID_MM_DEVICE_IGNORE=1 gets set
>> for
>> both the entire USB device and every single usb interface, which
>> seems
>> unnecessary.
>>
>> The reason we did this originally was that we (or at least I) didn't
>> want people blacklisting specific USB interfaces, since that just
>> papers over problems that we should fix in MM itself (either by
>> fixing
>> the bug or adjusting MM logic to find the right port) or encourages
>> behavior that leads to conflicts like blacklisting a status port so
>> it
>> can be used by some other program at the same time.
>
> That all said, I guess it doesn't hurt since MM has specific code to
> find the parent usb_device and check that for ID_MM_DEVICE_IGNORE.

Oh I see that reasoning now. Maybe the unnecessary check is then the
SUBSYSTEM!="usb" one then? Checking for "usb_device" is more
restrictive than just "usb".

-- 
Aleksander
https://aleksander.es


More information about the ModemManager-devel mailing list