[PATCH 2/7] GPS is configurable by DGPS_ENABLE variable

Dan Williams dcbw at redhat.com
Thu Feb 4 16:04:50 UTC 2016


On Tue, 2016-02-02 at 15:30 +0100, tomas.jura1 at gmail.com wrote:
> From: Tomas Jura <tomas_jura1 at gmail.com>
> 
> ---
>  plugins/mbm/mm-broadband-modem-mbm.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/plugins/mbm/mm-broadband-modem-mbm.c b/plugins/mbm/mm
> -broadband-modem-mbm.c
> index bfd26da..efd4f63 100644
> --- a/plugins/mbm/mm-broadband-modem-mbm.c
> +++ b/plugins/mbm/mm-broadband-modem-mbm.c
> @@ -1433,8 +1433,10 @@ parent_enable_location_gathering_ready
> (MMIfaceModemLocation *self,
>  
>      if (start_gps) {
>          gchar *s_gps_interval = getenv("GPS_INTERVAL");
> -        gchar *buf = g_strdup_printf("AT*E2GPSCTL=1,%d,0",
> -                                     s_gps_interval ?
> CLAMP(atoi(s_gps_interval),1,60) : MBM_GPS_NMEA_INTERVAL );
> +        gchar *s_dgps = getenv("DGPS_ENABLE");
> +        gchar *buf = g_strdup_printf("AT*E2GPSCTL=1,%d,%d",
> +                                     s_gps_interval ?
> CLAMP(atoi(s_gps_interval),1,60) : MBM_GPS_NMEA_INTERVAL,
> +                                     s_dgps ?
> CLAMP(atoi(s_dgps),0,1) : 0 );
>          mm_base_modem_at_command_full (MM_BASE_MODEM (self),
>                                        
>  mm_base_modem_peek_port_primary (MM_BASE_MODEM (self)),
>                                         buf,

Is there ever a reason to *not* use DGPS if it's available?  Does it
increase startup time when AGPS is not used?

Dan


More information about the ModemManager-devel mailing list