[PATCH 0/5] Thuraya XT satellite modem plugin, v3
Thomas Sailer
sailer at sailer.dynip.lugs.ch
Thu Feb 11 12:45:07 UTC 2016
From: Thomas Sailer <t.sailer at alumni.ethz.ch>
This is the third version of the Thuraya XT satellite modem plugin patch.
I should have implemented all of Aleksanders review comments except the modem strings, namely:
- Changes to core AT command parsing are now in separate patches each; the plugin
itself is one single patch, I do not see a reasonable way to split it
- CPMS response: the space separation method is indeed pretty stupid and probably
only Thuraya XT does this, so I've moved it into the Thuraya plugin, by specializing
the load_supported_storages interface; now uses g_strsplit
- single line copyright notices
- remove commented out cruft
- remove MM_BASE_MODEM_MAX_TIMEOUT
- still using vendor string; mm-plugin seems to be filtering with the PCI vendor/product
ID of the USB host controller, and not the USB vendor/product IDs of the device...
Thomas Sailer (5):
allow optional quotes in +CREG: <stat>,"<lac>","<ci>" (GSM 07.07
CREG=2 unsolicited) pattern; add testcase for Thuraya XT
allow optional whitespace in +CGDCONT response; add testcase for
Thuraya XT
allow space before ICCID in +CRSM response. Thuraya XT sends +CRSM:
144, 0, 9888...
allow space in response to +CRSM=176,28589,0,0,4 (mnc) and
+CRSM=176,28486,0,0,17 (spn)
add plugin for the Thuraya XT satellite phone modem
plugins/Makefile.am | 25 ++
plugins/thuraya/mm-broadband-modem-thuraya.c | 295 +++++++++++++++++++++
plugins/thuraya/mm-broadband-modem-thuraya.h | 50 ++++
plugins/thuraya/mm-modem-helpers-thuraya.c | 156 +++++++++++
plugins/thuraya/mm-modem-helpers-thuraya.h | 27 ++
plugins/thuraya/mm-plugin-thuraya.c | 85 ++++++
plugins/thuraya/mm-plugin-thuraya.h | 48 ++++
.../thuraya/tests/test-mm-modem-helpers-thuraya.c | 131 +++++++++
src/mm-base-sim.c | 6 +-
src/mm-modem-helpers.c | 6 +-
src/tests/test-modem-helpers.c | 25 ++
11 files changed, 848 insertions(+), 6 deletions(-)
create mode 100644 plugins/thuraya/mm-broadband-modem-thuraya.c
create mode 100644 plugins/thuraya/mm-broadband-modem-thuraya.h
create mode 100644 plugins/thuraya/mm-modem-helpers-thuraya.c
create mode 100644 plugins/thuraya/mm-modem-helpers-thuraya.h
create mode 100644 plugins/thuraya/mm-plugin-thuraya.c
create mode 100644 plugins/thuraya/mm-plugin-thuraya.h
create mode 100644 plugins/thuraya/tests/test-mm-modem-helpers-thuraya.c
--
2.5.0
More information about the ModemManager-devel
mailing list