[PATCH v2] port-serial: rework response parsing

Dan Williams dcbw at redhat.com
Fri Jan 22 10:55:44 PST 2016


On Fri, 2016-01-22 at 19:05 +0100, Aleksander Morgado wrote:
> On 22/01/16 18:00, Dan Williams wrote:
> > > > Patch looks good to me, I actually have no comments at all, and
> > > > it
> > > > seemed to work OK on 3 modems (including 2 with QCDM) :)  Nice
> > > > cleanup.
> > Since this patch applies on top of the original "port-serial:
> > remove
> > response buffer when an error is returned" patch, were you thinking
> > of
> > pushing the two separately to record the bug fix that the first one
> > has?
> 
> Actually I was going to skip the first one all together. Maybe the
> other
> one could go to mm-1-4 and the big one to master? or not worth?

I think it's worth committing the first patch to mm-1-4.

I only noticed the new v2 was diffed off the original patch, so you'd
need to squash for master then if you don't want them separate.

Dan


More information about the ModemManager-devel mailing list