mbm plugin gps improvements

[Aleksander Morgado]

On Fri, Jan 29, 2016 at 2:58 PM, Tomas Jura <tomas.jura1 at gmail.com> wrote:
> On 29.1.2016 17:31, Aleksander Morgado wrote:
>>
>> On Fri, Jan 29, 2016 at 1:00 AM, Tomas Jura <tomas.jura1 at gmail.com> wrote:
>>>
>>> The quick open/close action after the gps unmanaged end (patch #4 "flush
>>> unmanaged GPS port after GPS is stopped") serves for draining the
>>> remaining
>>> GPS sentences from the gps port. Without the drain some gps sentences can
>>> remain in the input buffer and those debris are offered as an input
>>> during
>>> the next gps read (for example after few hours). Reading such trash
>>> confuses
>>> the reader of GPS sentences. The modes NMEA and RAW do the drain of the
>>> port
>>> (during close). My patch just introduce the "drain and close" scenario to
>>> the unmanaged mode.
>>
>> What about the AT*E2GPSCTL=0 command on disabling GPS? Does it not
>> need to go to the GPS data port, as we did when enabling GPS? If that
>> is the case, the open/close would be implicit as we need to send an AT
>> command.
>>
> The AT*E2GPSCTL=0 goes into the control port, not to the gps data port.
> Patch drains the gps data port.
>
> AFAIK the gps data port is not usable as a control port once switched to the
> gps data mode.
> (source: http://www.natisbad.org/E4300/Dell_Wireless_5530_AT_cmd_ref.html)

Ok, understood.

Not 100% sure yet that we're the ones responsible for that explicit
port drain anyway, but as we're the ones disabling the GPS, it may
make sense.

-- 
Aleksander
https://aleksander.es