[PATCH 2/2] Telit plugin: add support to SIM hot swap

Carlo Lobrano c.lobrano at gmail.com
Mon Jul 11 12:14:09 UTC 2016


On 11 July 2016 at 14:09, Aleksander Morgado <aleksander at aleksander.es>
wrote:

> You shouldn't be passing the return of g_regex_new() directly to
> mm_port_serial_at_add_unsolicited_msg_handler(), as that method takes
> its own reference of the GRegex, and therefore the regex would be
> leaking afterwards. You should g_regex_new() and store it in a local
> variable, pass that variable to
> mm_port_serial_at_add_unsolicited_msg_handler() and then
> g_regex_unref() the variable.
>


​Oh, sorry, I missed that point in the first review​
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/modemmanager-devel/attachments/20160711/59a29610/attachment.html>


More information about the ModemManager-devel mailing list