[PATCH 13/14] zte, udev: avoid making the rules tty-only, and simplify single vendor check

Dan Williams dcbw at redhat.com
Thu Jul 28 18:17:38 UTC 2016


On Thu, 2016-07-28 at 18:42 +0200, Aleksander Morgado wrote:
> On Thu, Jul 28, 2016 at 5:38 PM, Dan Williams <dcbw at redhat.com>
> wrote:
> > 
> > On Thu, 2016-07-28 at 00:14 +0200, Aleksander Morgado wrote:
> > > 
> > > The rules were matched only against devices with an exact 'tty'
> > > subsystem, and
> > > that means that we were not properly adding additional tags on
> > > e.g.
> > > wwan or
> > > cdc-wdm devices.
> > > 
> > Good catch, though perhaps we want to limit the PORT_TYPE tags to
> > tty?
> > Maybe if ZTE re-uses IDs in the future we'd end up with a WDM port
> > conflict.
> Not sure if worth; at the end the port type tags are only read in MM
> if they're in TTYs anyway.

Fair enough.

Dan


More information about the ModemManager-devel mailing list