Probing cancellations

[Dan Williams]

On Sun, 2016-03-06 at 23:00 +0100, Aleksander Morgado wrote:
> Hey Dan,
> 
> On Tue, Mar 1, 2016 at 10:47 AM, Aleksander Morgado
> <aleksander at aleksander.es> wrote:
> > 
> > On Mon, Feb 29, 2016 at 11:33 PM, Dan Williams <dcbw at redhat.com>
> > wrote:
> > > 
> > > For a Sony Ericsson MD300 this branch now reports:
> > > 
> > >   -------------------------
> > >   System   |         device:
> > > '/sys/devices/pci0000:00/0000:00:14.0/usb1/1-1'
> > >            |        drivers: 'cdc_acm, cdc_wdm, cdc_ether'
> > >            |         plugin: 'Ericsson MBM'
> > >            |   primary port: 'cdc-wdm4'
> > >            |          ports: 'cdc-wdm4 (at), ttyACM2 (at), cdc-
> > > wdm2 (at), cdc-wdm1 (at), enp0s20u1c3i9 (net), cdc-wdm3 (at),
> > > ttyACM1 (at)'
> > > 
> > > while git master reports:
> > > 
> > >   -------------------------
> > >   System   |         device:
> > > '/sys/devices/pci0000:00/0000:00:14.0/usb1/1-1'
> > >            |        drivers: 'cdc_wdm, cdc_acm, cdc_ether'
> > >            |         plugin: 'Ericsson MBM'
> > >            |   primary port: 'ttyACM1'
> > >            |          ports: 'ttyACM1 (at), cdc-wdm4 (at), cdc-
> > > wdm2 (at), cdc-wdm1 (at), enp0s20u1c3i9 (net), cdc-wdm3 (at),
> > > ttyACM2 (at)'
> > > 
> > > I honestly don't know if the wdm ports can be used as masters,
> > > but on
> > > these devices we've always used the ACM ports as the
> > > masters.  Possibly
> > > the new branch is just better at probing and for whatever reason
> > > the
> > > wdm ports complete more quickly?
> > Oh? I don't think I explicitly changed anything that would make a
> > difference there. But I think there shouldn't be any issue with a
> > cdc-wdm port being used as primary, as long as there's a net port
> > around. This is very likely some race condition that we don't
> > really
> > try to explicitly avoid (do we want to avoid that?).
> > 
> Do you think we can merge the branch to git master? We could tag a
> 1.5.90 version after this, and start preparing the next stable
> series.

Yeah, I think that's fine.  Aside from this, I didn't see any
regressions with the devices I tested.

Dan