[review] dcbw/mbm-connect-disconnect-cleanup: simplify and clean up mbm plugin connect and disconnect

[Aleksander Morgado]

On Tue, May 24, 2016 at 4:37 PM, Dan Williams <dcbw at redhat.com> wrote:
> On Fri, 2016-05-13 at 20:03 +0200, Aleksander Morgado wrote:
>> On Wed, May 11, 2016 at 8:26 PM, Dan Williams <dcbw at redhat.com>
>> wrote:
>> >
>> > Please review the dcbw/mbm-connect-disconnect-cleanup branch.
>> >
>> > https://cgit.freedesktop.org/ModemManager/ModemManager/log/?h=dcbw/
>> > mbm-connect-disconnect-cleanup
>> >
>> > Git commit comments should have a pretty good overview of what's
>> > going
>> > on; these were spawned out of the following bugs that Lubomir found
>> > doing some automated testing:
>> >
>> > https://bugs.freedesktop.org/show_bug.cgi?id=95302
>> > https://bugs.freedesktop.org/show_bug.cgi?id=95304
>> LGTM; but for the last one, "broadband-bearer-mbm: connect errors
>> should trigger a disconnect", shouldn't we do this in the more
>> generic
>> MMBroadbandBearer or MMBearer instead? Don't we already have
>> something
>> like that?
>
> We should do it more generically, yes.  There's already some logic in
> the Icera plugin to do it.  I'd say we clean that up after 1.6?

Sure thing, yes.


-- 
Aleksander
https://aleksander.es