Fwd: Cinterion plugin patch

[Aleksander Morgado]

On Sun, Nov 20, 2016 at 7:26 PM, matthew stanger <stangerm2 at gmail.com> wrote:
> Ok, so clearly I'm not as fast as I wish, but another patch never the less.
> This should be pretty close but I'll keep at it if there are any changes
> still needed so let me know :). Here are the changes since the first patch
> of this chain:
>
> Converted Enum types from all caps to camel case.
> Changed pdp_cid from gchar to guint
> Moved retry_count from ..CinterionPrivate to 3gppContext
> Changed all single like '//' to block '/*' comments
> Removed brackets from any case stamement which was not defining variables
> All state machines refactored so default state results in assert exit
> Changed states which were programing failure states from async errors to
> assert failures
> Replaced gusleep calls with g_timeout_add callbacks
> Fixed pdp_cid to map g_udev_device_get_property_as_int->ID_USB_INTERFACE_NUM
> to context instead of hardcoded usb# interface.
> Connect/Disconnect logic now has different contexts in addition to
> complete_and_free()
> Connect/Disconnect ctx is no longer stored in private info, and instead is
> not passed directly. This may be backed out in the future for a URC
> supporting patch.
> Changed pdp_cid matching logic from hard mapped USB0/1 strings to use udev
> Changed pdp_cid to read as hex value
> Removed retry logic, that logic should be left up to calling program
> Updated parenthesis spacing
> Provided context on Cinterion pdp_cid mapping in pdp_cid_map() function
> Added SWWAN parser unit test
> Moved SWWAN test back to bearer to avoid MM enable init issue
> SWWAN test for bearer creation will now cache
> Updated SWWAN parser to use Glist of struct for dual connections
> Provided context on optional <WWAN adapter> in code
> Deleted unnecessary peek_current_data_port in disconnect flow.
> Fixed send_write_command_ctx_connect pass by ref, when it should have been
> const
> Changed bearer_interface ctx from string cmp to int
> Fixed parenthesis & var spacing issues
> Fixed alignment issues

Great work! it looks really good now, although there are some small
things that could still be fixed. Let me prepare a branch with your
patch and I'll include some additional patches for you to review.

-- 
Aleksander
https://aleksander.es