incorrect 'locked' status

[Aleksander Morgado]

On Tue, Oct 18, 2016 at 8:19 AM, David McCullough
<david.mccullough at accelerated.com> wrote:
> I have had a problem here on the MC7304 using Vodfone SIMs (AU).
>
> ModemManager is flagging the device as locked (PIN lock) even though there
> is no lock on the SIM.
>
> I ran it with DEBUG (just the PIN / locked transition is attached).
>
> Fairly recent clone of ModemManager,  src/mm-iface-modem.c has not changed.
>
> The attached patch lets the modem connect fine but I figure it is probably
> not correct.
>
> Basically the new state (lock) is set to MM_MODEM_LOCK_UNKNOWN and the old
> state (old_lock) is also set to MM_MODEM_LOCK_UNKNOWN.  For this condition
> the code transitions to the "locked" state.
>
> Let me know if you need and more info or debug,

So, PIN1 is disabled and therefore we check PIN2 and it is "not
initialized", which we translate to UNKNOWN. In this case, we should
have provided the state of PIN1 and ignore the state of PIN2.

Can you test the attached patch?

-- 
Aleksander
https://aleksander.es
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-broadband-modem-qmi-don-t-use-PIN2-lock-state-if-unk.patch
Type: text/x-patch
Size: 1209 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/modemmanager-devel/attachments/20161018/28e23d33/attachment.bin>