[PATCH 4/5] core: use the kernel device object in the port object and the plugin interface

Dan Williams dcbw at redhat.com
Fri Sep 30 04:00:17 UTC 2016


On Thu, 2016-09-29 at 15:39 +0200, Aleksander Morgado wrote:
> The mm_base_modem_grab_port() now receives a MMKernelDevice directly
> from the
> plugin, which is then stored in the MMPort corresponding to the port.
> 
> This means that we have direct access to e.g. all properties set by
> udev rules
> everywhere, and we don't need additional GUdevClient objects (e.g.
> like the one
> used in the Huawei plugin to detect NDISDUP support during runtime).
> 
> For virtual ports (e.g. generated during unit tests), we have a new
> 'generic'
> kernel device object which just provides the values from the kernel
> device
> properties given during its creation.

LGTM.

Dan


More information about the ModemManager-devel mailing list