[PATCH 8/8] broadband-bearer: once connected, set flow control settings

Aleksander Morgado aleksander at aleksander.es
Sat Apr 1 15:40:07 UTC 2017


On Sat, Apr 1, 2017 at 5:57 AM, Dan Williams <dcbw at redhat.com> wrote:
>> +MMFlowControl
>> +mm_broadband_modem_get_connected_flow_control (MMBroadbandModem
>> *self)
>> +{
>> +    return self->priv->modem_flow_control;
>> +}
>
> This part is kinda icky; and mm-broadband-bearer has no other case of
> calling a mm_broadband_modem...() function.  Could we perhaps pass it
> as a property or something into the bearer on creation?  It's not like
> it's going to change over the bearer lifetime.

Yes, that is a very good idea, I'll make it a MMBroadbandBearer
property given during object creation.


-- 
Aleksander
https://aleksander.es


More information about the ModemManager-devel mailing list