[PATCH 0/1] mbim modem: disable location interface

Aleksander Morgado aleksander at aleksander.es
Sun Apr 2 07:18:08 UTC 2017


On Sat, Apr 1, 2017 at 10:11 PM, Thomas Voß
<thomas.voss.bochum at gmail.com> wrote:
> A simple patch to avoid MBIM modems reporting that they support the location interface.
> I haven't submitted patches to mailing list in quite a while, so please bear with me
> while I'm learning.

No problem! What you did is perfectly fine. One extra tip:

When sending a single patch with git send-email, you don't really need
a cover letter (i.e. the PATCH 0/N email). Instead, you can abuse the
email formatting and embed the introduction email you would have in
the cover letter directly in the patch itself (e.g. with the
--annotate option in git send-email). Just make sure the format of the
introductory text goes inserted AFTER the commit message, like this:

<snip>
MBIM does not support 3gpp location data right now. For that,
we make sure that the location interface is not reported as
supported by MBIM modems.
---

You add an extra line with "---" after the one you find in the patch,
and you add your introductory message in between. The content between
the two lines with "---" will not be included as part of the commit
message when it is "git am"-ed, but will still be visible in the patch
email.

---
 src/mm-broadband-modem-mbim.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)
<snip>


-- 
Aleksander
https://aleksander.es


More information about the ModemManager-devel mailing list