[PATCH 1/1] mbim-modem: disable location interface

[Aleksander Morgado]

On Sat, Apr 1, 2017 at 10:11 PM, Thomas Voß
<thomas.voss.bochum at gmail.com> wrote:
> MBIM does not support 3gpp location data right now. For that,
> we make sure that the location interface is not reported as
> supported by MBIM modems.
> ---

Ideally, we would be checking if the MBIM modem supports QMI over
MBIM, and defaulting to the QMI implementation if so, but that
wouldn't apply only to the location interface.

Anyway, I think this patch isn't bad, given that MBIM doesn't really
report any LAC/CID.

Pushed to git master

>  src/mm-broadband-modem-mbim.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>
> diff --git a/src/mm-broadband-modem-mbim.c b/src/mm-broadband-modem-mbim.c
> index c5286a3f..0d1126d4 100644
> --- a/src/mm-broadband-modem-mbim.c
> +++ b/src/mm-broadband-modem-mbim.c
> @@ -35,6 +35,7 @@
>  #include "mm-bearer-list.h"
>  #include "mm-iface-modem.h"
>  #include "mm-iface-modem-3gpp.h"
> +#include "mm-iface-modem-location.h"
>  #include "mm-iface-modem-messaging.h"
>  #include "mm-iface-modem-signal.h"
>  #include "mm-sms-part-3gpp.h"
> @@ -45,12 +46,14 @@
>
>  static void iface_modem_init           (MMIfaceModem          *iface);
>  static void iface_modem_3gpp_init      (MMIfaceModem3gpp      *iface);
> +static void iface_modem_location_init  (MMIfaceModemLocation  *iface);
>  static void iface_modem_messaging_init (MMIfaceModemMessaging *iface);
>  static void iface_modem_signal_init    (MMIfaceModemSignal    *iface);
>
>  G_DEFINE_TYPE_EXTENDED (MMBroadbandModemMbim, mm_broadband_modem_mbim, MM_TYPE_BROADBAND_MODEM, 0,
>                          G_IMPLEMENT_INTERFACE (MM_TYPE_IFACE_MODEM, iface_modem_init)
>                          G_IMPLEMENT_INTERFACE (MM_TYPE_IFACE_MODEM_3GPP, iface_modem_3gpp_init)
> +                        G_IMPLEMENT_INTERFACE (MM_TYPE_IFACE_MODEM_LOCATION, iface_modem_location_init)
>                          G_IMPLEMENT_INTERFACE (MM_TYPE_IFACE_MODEM_MESSAGING, iface_modem_messaging_init)
>                          G_IMPLEMENT_INTERFACE (MM_TYPE_IFACE_MODEM_SIGNAL, iface_modem_signal_init))
>
> @@ -3288,6 +3291,15 @@ iface_modem_3gpp_init (MMIfaceModem3gpp *iface)
>  }
>
>  static void
> +iface_modem_location_init (MMIfaceModemLocation *iface)
> +{
> +    iface->load_capabilities = NULL;
> +    iface->load_capabilities_finish = NULL;
> +    iface->enable_location_gathering = NULL;
> +    iface->enable_location_gathering_finish = NULL;
> +}
> +
> +static void
>  iface_modem_messaging_init (MMIfaceModemMessaging *iface)
>  {
>      iface->check_support = messaging_check_support;
> --
> 2.11.0
>
> _______________________________________________
> ModemManager-devel mailing list
> ModemManager-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel



-- 
Aleksander
https://aleksander.es