[PATCH] novatel-lte: revert to original plugin library name

Aleksander Morgado aleksander at aleksander.es
Thu Apr 6 18:15:43 UTC 2017


On 03/04/17 23:16, Dan Williams wrote:
> On Mon, 2017-04-03 at 13:05 -0700, Ben Chan wrote:
>> Commit f9c63bfa0 "build,plugins: update build rules" accidentally
>> changed the Novatel LTE plugin from 'libmm-plugins-novatel-lte.so' to
>> 'libmm-plugins-novatel_lte.so'. The name becomes inconsistent with
>> other
>> plugin names.
> 
> Seems fine to me.
> 
> Dan
> 

Pushed to git master, thanks!

>> ---
>> It probably doesn't matter how the plugin library is named, but the
>> original
>> name is preferred for consistency.
>>
>> Ben
>>
>>  plugins/Makefile.am | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/plugins/Makefile.am b/plugins/Makefile.am
>> index 596866b7..2a4ff2b6 100644
>> --- a/plugins/Makefile.am
>> +++ b/plugins/Makefile.am
>> @@ -720,7 +720,7 @@ libmm_plugin_thuraya_la_LIBADD   =
>> $(builddir)/libhelpers-thuraya.la
>>  # plugin: novatel lte
>>  ####################################################################
>> ############
>>  
>> -pkglib_LTLIBRARIES += libmm-plugin-novatel_lte.la
>> +pkglib_LTLIBRARIES += libmm-plugin-novatel-lte.la
>>  libmm_plugin_novatel_lte_la_SOURCES = \
>>  	novatel/mm-plugin-novatel-lte.c \
>>  	novatel/mm-plugin-novatel-lte.h \


-- 
Aleksander
https://aleksander.es


More information about the ModemManager-devel mailing list