[PATCH] telit: add error_code recognition to +CSIM parser

Tue Apr 18 15:20:03 UTC 2017

> On 18 April 2017 at 15:32 Colin Helliwell <colin.helliwell at ln-systems.com> wrote:
> 
> > On 18 April 2017 at 15:05 Carlo Lobrano <c.lobrano at gmail.com> wrote:
> > 
> > Hi Aleksander,
> > 
> > see below my reply
> > 
> > Il giovedì 6 aprile 2017, Aleksander Morgado <aleksander at aleksander.es> ha scritto:
> > 
> > > Hey Carlo,
> > > 
> > > On 04/04/17 14:55, Carlo Lobrano wrote:
> > > 
> > > > *   Refactored mm_telit_parse_csim_response in order to correctly recognize the
> > > > following +CSIM error codes:
> > > > 
> > > >         *   6300 - Verification failed
> > > >     *   6983 - Authentication method blocked
> > > >     *   6984 - Reference data invalidated
> > > >     *   6A86 - Incorrect parameters
> > > >     *   6A88 - Reference data not found
> > > > 
> > > > *   Updated correspondent tests.
> > > > 
> > > > *   Finally, some minor changes in other files for better error logging
> > > > 
> > > > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=100374
> > > > 
> > > > ---
> > > > 
> > > > As a side note, I observed that sometimes the modem replies with error
> > > > code
> > > > 
> > > > 6A86 - Incorrect parameters
> > > > 
> > > > when #QSS: 3 has not been received yet. This seems to be a modem's bug
> > > > because the very same request is accepted as correct when issued later,
> > > > namely when the SIM is ready.
> 
> On my list of things to log further, but I've also seen (probably, I think, with SIM PIN enabled) those kind of +CSIM errors

To keep things simple for now, these logs are with an unlocked SIM. This is with my modified Cinterion plugin, which I've chucked the +CSIM's into.

EHS5:
  Doesn't support ^SPIC at all. 
  But (probably) all good with the +CSIM method.

BGS2:
  Doesn't support ^SPIC with an additional parameter - docs say that AT^SPIC="SC" will give the 'current' counter i.e. normally PIN retries, but instead the PUK retries after 3 failed PIN attempts....  (similarly for "P2" - might be PIN2, might be PUK2)

  Not sure why PS and PN fail.

  +CSIM gives errors [6A88] for PIN2/PUK2

  As I alluded to the other day - it can perhaps give best info from the +CSIM method. But not for PIN2 - in this case it seems able to get *this* one from ^SPIC="P2" but not from +CSIM!

I suspect my contributions might not be making things any easier.....   I'll get my coat....!  :S
But anyway, fwiw:

Cinterion BGS2, No Lock, Not yet enabled
========================================

ModemManager[1042]: <debug> [1492526407.269718] [src/mm-port-serial-at.c:459] debug_log(): (ttyMux1): --> 'AT+CSIM=10,"0020000100"<CR>'	{PIN}
ModemManager[1042]: <debug> [1492526407.318526] [src/mm-port-serial-at.c:459] debug_log(): (ttyMux1): <-- '<CR><LF>+CSIM: 4,"63C3"<CR><LF><CR><LF>OK<CR><LF>'

ModemManager[1042]: <debug> [1492526407.322674] [src/mm-port-serial-at.c:459] debug_log(): (ttyMux1): --> 'AT+CSIM=10,"002C000100"<CR>'	{PUK}
ModemManager[1042]: <debug> [1492526407.371446] [src/mm-port-serial-at.c:459] debug_log(): (ttyMux1): <-- '<CR><LF>+CSIM: 4,"63CA"<CR><LF><CR><LF>OK<CR><LF>'

ModemManager[1042]: <debug> [1492526407.375512] [src/mm-port-serial-at.c:459] debug_log(): (ttyMux1): --> 'AT+CSIM=10,"0020008100"<CR>'	{PIN2}
ModemManager[1042]: <debug> [1492526407.424717] [src/mm-port-serial-at.c:459] debug_log(): (ttyMux1): <-- '<CR><LF>+CSIM: 4,"6A88"<CR><LF><CR><LF>OK<CR><LF>'
ModemManager[1042]: <warn>  [1492526407.426307] [plugins/cinterion/mm-broadband-modem-cinterion.c:1453] load_unlock_retries_ready(): Parse error in step 2: Could not parse reponse '+CSIM: 4,"6A88"'.
ModemManager[1042]: <debug> [1492526407.427384] [plugins/cinterion/mm-broadband-modem-cinterion.c:1458] load_unlock_retries_ready(): Couldn't parse retry count value for lock 'sim-pin2'

ModemManager[1042]: <debug> [1492526407.430747] [src/mm-port-serial-at.c:459] debug_log(): (ttyMux1): --> 'AT+CSIM=10,"002C008100"<CR>'	{PUK2}
ModemManager[1042]: <debug> [1492526407.480156] [src/mm-port-serial-at.c:459] debug_log(): (ttyMux1): <-- '<CR><LF>+CSIM: 4,"6A88"<CR><LF><CR><LF>OK<CR><LF>'
ModemManager[1042]: <warn>  [1492526407.481684] [plugins/cinterion/mm-broadband-modem-cinterion.c:1453] load_unlock_retries_ready(): Parse error in step 3: Could not parse reponse '+CSIM: 4,"6A88"'.
ModemManager[1042]: <debug> [1492526407.482766] [plugins/cinterion/mm-broadband-modem-cinterion.c:1458] load_unlock_retries_ready(): Couldn't parse retry count value for lock 'sim-puk2'

ModemManager[1042]: <debug> [1492526407.486088] [src/mm-port-serial-at.c:459] debug_log(): (ttyMux1): --> 'AT^SPIC="SC"<CR>'
ModemManager[1042]: <debug> [1492526407.516319] [src/mm-port-serial-at.c:459] debug_log(): (ttyMux1): <-- '<CR><LF>^SPIC: 3<CR><LF><CR><LF>OK<CR><LF>'

ModemManager[1042]: <debug> [1492526407.520086] [src/mm-port-serial-at.c:459] debug_log(): (ttyMux1): --> 'AT^SPIC="SC",1<CR>'
ModemManager[1042]: <debug> [1492526407.552152] [src/mm-port-serial-at.c:459] debug_log(): (ttyMux1): <-- '<CR><LF>+CME ERROR: 100<CR><LF>'
ModemManager[1042]: <debug> [1492526407.553439] [src/mm-serial-parsers.c:364] mm_serial_parser_v1_parse(): Got failure code 100: Unknown error
ModemManager[1042]: <debug> [1492526407.554529] [plugins/cinterion/mm-broadband-modem-cinterion.c:1430] load_unlock_retries_ready(): Couldn't load retry count for lock 'sim-puk': Unknown error

ModemManager[1042]: <debug> [1492526407.557932] [src/mm-port-serial-at.c:459] debug_log(): (ttyMux1): --> 'AT^SPIC="P2"<CR>'
ModemManager[1042]: <debug> [1492526407.588044] [src/mm-port-serial-at.c:459] debug_log(): (ttyMux1): <-- '<CR><LF>^SPIC: 3<CR><LF><CR><LF>OK<CR><LF>'

ModemManager[1042]: <debug> [1492526407.591749] [src/mm-port-serial-at.c:459] debug_log(): (ttyMux1): --> 'AT^SPIC="P2",1<CR>'
ModemManager[1042]: <debug> [1492526407.623793] [src/mm-port-serial-at.c:459] debug_log(): (ttyMux1): <-- '<CR><LF>+CME ERROR: 100<CR><LF>'
ModemManager[1042]: <debug> [1492526407.625094] [src/mm-serial-parsers.c:364] mm_serial_parser_v1_parse(): Got failure code 100: Unknown error
ModemManager[1042]: <debug> [1492526407.626165] [plugins/cinterion/mm-broadband-modem-cinterion.c:1430] load_unlock_retries_ready(): Couldn't load retry count for lock 'sim-puk2': Unknown error

ModemManager[1042]: <debug> [1492526407.629506] [src/mm-port-serial-at.c:459] debug_log(): (ttyMux1): --> 'AT^SPIC="PS"<CR>'
ModemManager[1042]: <debug> [1492526407.659024] [src/mm-port-serial-at.c:459] debug_log(): (ttyMux1): <-- '<CR><LF>+CME ERROR: 256<CR><LF>'
ModemManager[1042]: <debug> [1492526407.660309] [src/mm-error-helpers.c:131] mm_mobile_equipment_error_for_code(): Invalid mobile equipment error code: 256
ModemManager[1042]: <debug> [1492526407.661367] [src/mm-serial-parsers.c:364] mm_serial_parser_v1_parse(): Got failure code 100: Unknown error
ModemManager[1042]: <debug> [1492526407.662405] [plugins/cinterion/mm-broadband-modem-cinterion.c:1430] load_unlock_retries_ready(): Couldn't load retry count for lock 'ph-fsim-pin': Unknown error

ModemManager[1042]: <debug> [1492526407.665698] [src/mm-port-serial-at.c:459] debug_log(): (ttyMux1): --> 'AT^SPIC="PS",1<CR>'
ModemManager[1042]: <debug> [1492526407.697818] [src/mm-port-serial-at.c:459] debug_log(): (ttyMux1): <-- '<CR><LF>+CME ERROR: 100<CR><LF>'
ModemManager[1042]: <debug> [1492526407.699092] [src/mm-serial-parsers.c:364] mm_serial_parser_v1_parse(): Got failure code 100: Unknown error
ModemManager[1042]: <debug> [1492526407.700164] [plugins/cinterion/mm-broadband-modem-cinterion.c:1430] load_unlock_retries_ready(): Couldn't load retry count for lock 'ph-fsim-puk': Unknown error

ModemManager[1042]: <debug> [1492526407.703500] [src/mm-port-serial-at.c:459] debug_log(): (ttyMux1): --> 'AT^SPIC="PN"<CR>'
ModemManager[1042]: <debug> [1492526407.733142] [src/mm-port-serial-at.c:459] debug_log(): (ttyMux1): <-- '<CR><LF>+CME ERROR: 256<CR><LF>'
ModemManager[1042]: <debug> [1492526407.734413] [src/mm-error-helpers.c:131] mm_mobile_equipment_error_for_code(): Invalid mobile equipment error code: 256
ModemManager[1042]: <debug> [1492526407.735443] [src/mm-serial-parsers.c:364] mm_serial_parser_v1_parse(): Got failure code 100: Unknown error
ModemManager[1042]: <debug> [1492526407.736512] [plugins/cinterion/mm-broadband-modem-cinterion.c:1430] load_unlock_retries_ready(): Couldn't load retry count for lock 'ph-net-pin': Unknown error

ModemManager[1042]: <debug> [1492526407.740463] [src/mm-port-serial-at.c:459] debug_log(): (ttyMux1): --> 'AT^SPIC="PN",1<CR>'
ModemManager[1042]: <debug> [1492526407.772466] [src/mm-port-serial-at.c:459] debug_log(): (ttyMux1): <-- '<CR><LF>+CME ERROR: 100<CR><LF>'
ModemManager[1042]: <debug> [1492526407.773754] [src/mm-serial-parsers.c:364] mm_serial_parser_v1_parse(): Got failure code 100: Unknown error
ModemManager[1042]: <debug> [1492526407.774838] [plugins/cinterion/mm-broadband-modem-cinterion.c:1430] load_unlock_retries_ready(): Couldn't load retry count for lock 'ph-net-puk': Unknown error

=> unlock retries: 'sim-pin (3), sim-pin2 (3), sim-puk (10)'

Cinterion EHS5, No Lock, Not yet enabled
========================================

ModemManager[900]: <debug> [1492527618.746856] [src/mm-port-serial-at.c:459] debug_log(): (ttyMux1): --> 'AT+CSIM=10,"0020000100"<CR>'	{PIN}
ModemManager[900]: <debug> [1492527618.801909] [src/mm-port-serial-at.c:459] debug_log(): (ttyMux1): <-- '<CR><LF>+CSIM: 4,"63C3"<CR><LF>'
ModemManager[900]: <debug> [1492527618.804560] [src/mm-port-serial-at.c:459] debug_log(): (ttyMux1): <-- '<CR><LF>OK<CR><LF>'

ModemManager[900]: <debug> [1492527618.808669] [src/mm-port-serial-at.c:459] debug_log(): (ttyMux1): --> 'AT+CSIM=10,"002C000100"<CR>'	{PUK}
ModemManager[900]: <debug> [1492527618.863271] [src/mm-port-serial-at.c:459] debug_log(): (ttyMux1): <-- '<CR><LF>+CSIM: 4,"63CA"<CR><LF>'
ModemManager[900]: <debug> [1492527618.865886] [src/mm-port-serial-at.c:459] debug_log(): (ttyMux1): <-- '<CR><LF>OK<CR><LF>'

ModemManager[900]: <debug> [1492527618.869813] [src/mm-port-serial-at.c:459] debug_log(): (ttyMux1): --> 'AT+CSIM=10,"0020008100"<CR>'	{PIN2}
ModemManager[900]: <debug> [1492527618.929703] [src/mm-port-serial-at.c:459] debug_log(): (ttyMux1): <-- '<CR><LF>+CSIM: 4,"63C3"<CR><LF>'
ModemManager[900]: <debug> [1492527618.935837] [src/mm-port-serial-at.c:459] debug_log(): (ttyMux1): <-- '<CR><LF>OK<CR><LF>'

ModemManager[900]: <debug> [1492527618.939848] [src/mm-port-serial-at.c:459] debug_log(): (ttyMux1): --> 'AT+CSIM=10,"002C008100"<CR>'	{PUK2}
ModemManager[900]: <debug> [1492527618.995045] [src/mm-port-serial-at.c:459] debug_log(): (ttyMux1): <-- '<CR><LF>+CSIM: 4,"63CA"<CR><LF>'
ModemManager[900]: <debug> [1492527618.996707] [src/mm-port-serial-at.c:459] debug_log(): (ttyMux1): <-- '<CR><LF>OK<CR><LF>'

ModemManager[900]: <debug> [1492527619.000753] [src/mm-port-serial-at.c:459] debug_log(): (ttyMux1): --> 'AT^SPIC="SC"<CR>'
ModemManager[900]: <debug> [1492527619.031418] [src/mm-port-serial-at.c:459] debug_log(): (ttyMux1): <-- '<CR><LF>+CME ERROR: 100<CR><LF>'
ModemManager[900]: <debug> [1492527619.032767] [src/mm-serial-parsers.c:364] mm_serial_parser_v1_parse(): Got failure code 100: Unknown error
ModemManager[900]: <debug> [1492527619.033898] [plugins/cinterion/mm-broadband-modem-cinterion.c:1430] load_unlock_retries_ready(): Couldn't load retry count for lock 'sim-pin': Unknown error

ModemManager[900]: <debug> [1492527619.037460] [src/mm-port-serial-at.c:459] debug_log(): (ttyMux1): --> 'AT^SPIC="SC",1<CR>'
ModemManager[900]: <debug> [1492527619.070827] [src/mm-port-serial-at.c:459] debug_log(): (ttyMux1): <-- '<CR><LF>+CME ERROR: 100<CR><LF>'
ModemManager[900]: <debug> [1492527619.072163] [src/mm-serial-parsers.c:364] mm_serial_parser_v1_parse(): Got failure code 100: Unknown error
ModemManager[900]: <debug> [1492527619.073267] [plugins/cinterion/mm-broadband-modem-cinterion.c:1430] load_unlock_retries_ready(): Couldn't load retry count for lock 'sim-puk': Unknown error

ModemManager[900]: <debug> [1492527619.076702] [src/mm-port-serial-at.c:459] debug_log(): (ttyMux1): --> 'AT^SPIC="P2"<CR>'
ModemManager[900]: <debug> [1492527619.107959] [src/mm-port-serial-at.c:459] debug_log(): (ttyMux1): <-- '<CR><LF>+CME ERROR: 100<CR><LF>'
ModemManager[900]: <debug> [1492527619.109245] [src/mm-serial-parsers.c:364] mm_serial_parser_v1_parse(): Got failure code 100: Unknown error
ModemManager[900]: <debug> [1492527619.110332] [plugins/cinterion/mm-broadband-modem-cinterion.c:1430] load_unlock_retries_ready(): Couldn't load retry count for lock 'sim-pin2': Unknown error

ModemManager[900]: <debug> [1492527619.113686] [src/mm-port-serial-at.c:459] debug_log(): (ttyMux1): --> 'AT^SPIC="P2",1<CR>'
ModemManager[900]: <debug> [1492527619.147017] [src/mm-port-serial-at.c:459] debug_log(): (ttyMux1): <-- '<CR><LF>+CME ERROR: 100<CR><LF>'
ModemManager[900]: <debug> [1492527619.148348] [src/mm-serial-parsers.c:364] mm_serial_parser_v1_parse(): Got failure code 100: Unknown error
ModemManager[900]: <debug> [1492527619.149450] [plugins/cinterion/mm-broadband-modem-cinterion.c:1430] load_unlock_retries_ready(): Couldn't load retry count for lock 'sim-puk2': Unknown error

ModemManager[900]: <debug> [1492527619.152812] [src/mm-port-serial-at.c:459] debug_log(): (ttyMux1): --> 'AT^SPIC="PS"<CR>'
ModemManager[900]: <debug> [1492527619.183523] [src/mm-port-serial-at.c:459] debug_log(): (ttyMux1): <-- '<CR><LF>+CME ERROR: 100<CR><LF>'
ModemManager[900]: <debug> [1492527619.184852] [src/mm-serial-parsers.c:364] mm_serial_parser_v1_parse(): Got failure code 100: Unknown error
ModemManager[900]: <debug> [1492527619.185947] [plugins/cinterion/mm-broadband-modem-cinterion.c:1430] load_unlock_retries_ready(): Couldn't load retry count for lock 'ph-fsim-pin': Unknown error

ModemManager[900]: <debug> [1492527619.189360] [src/mm-port-serial-at.c:459] debug_log(): (ttyMux1): --> 'AT^SPIC="PS",1<CR>'
ModemManager[900]: <debug> [1492527619.222723] [src/mm-port-serial-at.c:459] debug_log(): (ttyMux1): <-- '<CR><LF>+CME ERROR: 100<CR><LF>'
ModemManager[900]: <debug> [1492527619.224096] [src/mm-serial-parsers.c:364] mm_serial_parser_v1_parse(): Got failure code 100: Unknown error
ModemManager[900]: <debug> [1492527619.225207] [plugins/cinterion/mm-broadband-modem-cinterion.c:1430] load_unlock_retries_ready(): Couldn't load retry count for lock 'ph-fsim-puk': Unknown error

ModemManager[900]: <debug> [1492527619.228583] [src/mm-port-serial-at.c:459] debug_log(): (ttyMux1): --> 'AT^SPIC="PN"<CR>'
ModemManager[900]: <debug> [1492527619.259250] [src/mm-port-serial-at.c:459] debug_log(): (ttyMux1): <-- '<CR><LF>+CME ERROR: 100<CR><LF>'
ModemManager[900]: <debug> [1492527619.260545] [src/mm-serial-parsers.c:364] mm_serial_parser_v1_parse(): Got failure code 100: Unknown error
ModemManager[900]: <debug> [1492527619.261633] [plugins/cinterion/mm-broadband-modem-cinterion.c:1430] load_unlock_retries_ready(): Couldn't load retry count for lock 'ph-net-pin': Unknown error

ModemManager[900]: <debug> [1492527619.265136] [src/mm-port-serial-at.c:459] debug_log(): (ttyMux1): --> 'AT^SPIC="PN",1<CR>'
ModemManager[900]: <debug> [1492527619.302619] [src/mm-port-serial-at.c:459] debug_log(): (ttyMux1): <-- '<CR><LF>+CME ERROR: 100<CR><LF>'
ModemManager[900]: <debug> [1492527619.304099] [src/mm-serial-parsers.c:364] mm_serial_parser_v1_parse(): Got failure code 100: Unknown error
ModemManager[900]: <debug> [1492527619.305217] [plugins/cinterion/mm-broadband-modem-cinterion.c:1430] load_unlock_retries_ready(): Couldn't load retry count for lock 'ph-net-puk': Unknown error

=> unlock retries: 'sim-pin (3), sim-pin2 (3), sim-puk (10), sim-puk2 (10)'