Handling QSS unsolicited in power state transitions

[Carlo Lobrano]

It seems that sometimes the decision to send the #QSS=0 is taken with some
delay (with HE910) and in these cases it arrives quite late (10-13 seconds)
and disabling the notifications and then re-enabling them later does not
avoid it.
Considered this, I would go with ignoring #QSS unsolicited between +CFUN=4
and +CFUN=1. The vast majority of telit modems switches the SIM off so this
unsolicited is expected (actually, only the latest LE910 V2 FW do not do
that) and, of course, it's the only one we will receive 'till +CFUN=1.
Moreover ignoring QSS requires a lot less code than disabling/enabling its
emission.

On Tue, 1 Aug 2017 at 13:14 Carlo Lobrano <c.lobrano at gmail.com> wrote:

> Yes, I agree. That's why it's on a different patch
>
> On Tue, 1 Aug 2017, 13:12 Aleksander Morgado, <aleksander at aleksander.es>
> wrote:
>
>> On Tue, Aug 1, 2017 at 12:31 PM, Carlo Lobrano <c.lobrano at gmail.com>
>> wrote:
>> >> Aren't the sim hot swap unsolicited messages received always,
>> regardless
>> >> of whether the modem is enabled or disabled?
>> >
>> > disabling_stopped function releases both ports contexts, so we don't
>> receive
>> > unsolicited on SIM swap ports.
>> >
>>
>> Wait, I don't think that's ok. The SIM swap ports context is allocated
>> during initialization, and should exist until the object is destroyed.
>> We shouldn't be removing this context when the disable() happens,
>> otherwise we wouldn't get SIM hot swap events when the modem is
>> disabled.
>>
>> --
>> Aleksander
>> https://aleksander.es
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/modemmanager-devel/attachments/20170801/3c596768/attachment.html>