[PATCH] sms-part-cdma: add missing break statements in cause_code_to_delivery_state
Ben Chan
benchan at chromium.org
Thu Aug 3 04:53:32 UTC 2017
This patch fixes cause_code_to_delivery_state() by adding two missing
break statements for the case ERROR_CLASS_TEMPORARY and
ERROR_CLASS_PERMANENT in the `switch (error_class)` statement. Without
the break statements, the switch always falls through to the default and
returns MM_SMS_DELIVERY_STATE_UNKNOWN for an `error_class' of value
ERROR_CLASS_TEMPORARY or ERROR_CLASS_PERMANENT.
---
src/mm-sms-part-cdma.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/mm-sms-part-cdma.c b/src/mm-sms-part-cdma.c
index 3aa6b455..8d76bcec 100644
--- a/src/mm-sms-part-cdma.c
+++ b/src/mm-sms-part-cdma.c
@@ -273,8 +273,10 @@ cause_code_to_delivery_state (guint8 error_class,
return MM_SMS_DELIVERY_STATE_COMPLETED_RECEIVED;
case ERROR_CLASS_TEMPORARY:
delivery_state += 0x300;
+ break;
case ERROR_CLASS_PERMANENT:
delivery_state += 0x200;
+ break;
default:
return MM_SMS_DELIVERY_STATE_UNKNOWN;
}
--
2.14.0.rc1.383.gd1ce394fe2-goog
More information about the ModemManager-devel
mailing list