[PATCH] altair-lte: don't use send-delay=0

[Ben Chan]

On Aug 3, 2017 3:35 AM, "Aleksander Morgado" <aleksander at aleksander.es>
wrote:

On 02/08/17 07:16, Ben Chan wrote:
> As observed on some modems, send-delay=0 seems to break port probing.
> ---
>  plugins/altair/mm-plugin-altair-lte.c | 1 -
>  1 file changed, 1 deletion(-)
>

But the port probing with send delay 0 here should only happen when the
Altair LTE modem is the one being probed. Does this mean this modem
(0x216f:0x0047) doesn't like send-delay 0?


 I tested on two variants of the modem (same chipset, same VID:PID,
different modules; both support LTE band 13, one also supports band 4). The
newer one, which supports band 4+13,  doesn't like send-delay 0 :(


> diff --git a/plugins/altair/mm-plugin-altair-lte.c
b/plugins/altair/mm-plugin-altair-lte.c
> index 2338502b..7f6a7c0b 100644
> --- a/plugins/altair/mm-plugin-altair-lte.c
> +++ b/plugins/altair/mm-plugin-altair-lte.c
> @@ -83,7 +83,6 @@ mm_plugin_create (void)
>                        MM_PLUGIN_CUSTOM_AT_PROBE,     custom_at_probe,
>                        MM_PLUGIN_ALLOWED_SINGLE_AT,   TRUE,
>                        MM_PLUGIN_SEND_LF,             TRUE,
> -                      MM_PLUGIN_SEND_DELAY,          0,
>                        NULL));
>  }
>
>


--
Aleksander
https://aleksander.es
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/modemmanager-devel/attachments/20170803/626d4fc8/attachment.html>