[PATCH] mm-broadband-modem-mbim: reprobe on mbim-proxy death

Eric Caruso ejcaruso at chromium.org
Fri Aug 4 17:03:35 UTC 2017


Thanks for taking a look!

On Fri, Aug 4, 2017 at 5:39 AM, Aleksander Morgado
<aleksander at aleksander.es> wrote:
> Ideally mbim-proxy should never crash :) Do you have any issue that ends up in the proxy crashing, or is this just a nice to have recovery method?

Mostly this is a nice-to-have, but on Chrome OS it would improve the
user experience since mbim-proxy crashing causes MM to lose contact
with the modem but not really do anything about it. Instead of the
user having to realize this and toggle a bunch of switches until it
works again it would be cool if MM just tried to recover.

We turned off mbim-proxy on Chrome OS back when all the modem stuff
was still running as root, and I wanted to turn it back on so we can
concurrently use mbimcli but Ben also wanted us to have some handling
in case it disappears on us.

> But looking at this in a more generic way, if the MbimDevice reports "device-removed" then we should really try to handle that in ModemManager as an indication that the port is no longer valid, so let's try to support this as well.
>
> BTW; I'd love to see a patch also for QMI doing the same thing... :)

I don't have any QMI modems to test on at the moment, so I can write a
patch, but no guarantees on whether it works ;)

-Eric


More information about the ModemManager-devel mailing list