issue with Quectel EC20

[Aleksander Morgado]

On Thu, Dec 21, 2017 at 2:41 PM, Aleksander Morgado
<aleksander at aleksander.es> wrote:
>
>
>
> On Thu, Dec 21, 2017 at 2:15 PM, Piotr Figiel <figiel at gmail.com> wrote:
>>
>> Hi,
>>  I dug into the issue a little bit deeper and I think I found the
>> source of the problem.
>>  The connection state machine seem to enter a dead end in
>> mm-bearer-qmi.c on CONNECT_STEP_ENABLE_INDICATIONS_IPV4 case for
>> libqmi < 1.18.0.
>>  With this patch it works, you can include it if you find it OK, this
>> is on top of mm-1-6.
>>
>> Best regards, Piotr.
>>
>> From d5ffba8afb2c18e51eb0a982b31a0c92b7337e64 Mon Sep 17 00:00:00 2001
>> From: Piotr Figiel <p.figiel at camlintechnologies.com>
>> Date: Thu, 21 Dec 2017 14:08:35 +0100
>> Subject: [PATCH] bearer-qmi: fix connect with libqmi lower than 1.18
>>
>
> Ouch, good one! Pushed an updated patch to mm-1-6 that also considers the same thing in the IPv6 case a bit later.
>
> And found a related issue while looking at the code, going to fix that one as well.
>

Here's the other one I was referring to:
https://cgit.freedesktop.org/ModemManager/ModemManager/commit/?h=mm-1-6&id=5230ee4241042ca201075178d42fca8d89152753

Fixed in both git master and mm-1-6.

>
>
>>
>> ---
>>  src/mm-bearer-qmi.c | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/src/mm-bearer-qmi.c b/src/mm-bearer-qmi.c
>> index c75d5e4..c92e971 100644
>> --- a/src/mm-bearer-qmi.c
>> +++ b/src/mm-bearer-qmi.c
>> @@ -1156,8 +1156,10 @@ connect_context_step (ConnectContext *ctx)
>>                                                 ctx->cancellable,
>>                                                 (GAsyncReadyCallback)
>> connect_enable_indications_ipv4_ready,
>>                                                 ctx);
>> -#endif
>>          return;
>> +#else
>> +        ctx->step++;
>> +#endif
>>
>>      case CONNECT_STEP_START_NETWORK_IPV4: {
>>          QmiMessageWdsStartNetworkInput *input;
>> --
>> 2.7.4
>> _______________________________________________
>> ModemManager-devel mailing list
>> ModemManager-devel at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel
>
>
>
>
> --
> Aleksander
> https://aleksander.es




-- 
Aleksander
https://aleksander.es