[PATCH 1/3] kernel-device: handle SDIO device in find_physical_gudevdevice

Aleksander Morgado aleksander at aleksander.es
Fri Feb 24 18:56:55 UTC 2017


On Thu, Feb 23, 2017 at 8:45 PM, Ben Chan <benchan at chromium.org> wrote:
> ---
>  src/kerneldevice/mm-kernel-device-udev.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>

This one is probably ok; I'd add some more information in the commit
message, though (e.g. the explanation given in the cover letter in
PATCH 0/3)

> diff --git a/src/kerneldevice/mm-kernel-device-udev.c b/src/kerneldevice/mm-kernel-device-udev.c
> index 432832f4..763ccf86 100644
> --- a/src/kerneldevice/mm-kernel-device-udev.c
> +++ b/src/kerneldevice/mm-kernel-device-udev.c
> @@ -178,7 +178,7 @@ find_physical_gudevdevice (GUdevDevice *child)
>      const char *subsys, *type, *name;
>      guint32 i = 0;
>      gboolean is_usb = FALSE, is_pci = FALSE, is_pcmcia = FALSE, is_platform = FALSE;
> -    gboolean is_pnp = FALSE;
> +    gboolean is_pnp = FALSE, is_sdio = FALSE;
>
>      g_return_val_if_fail (child != NULL, NULL);
>
> @@ -233,6 +233,10 @@ find_physical_gudevdevice (GUdevDevice *child)
>                  is_pnp = TRUE;
>                  physdev = iter;
>                  break;
> +            } else if (is_sdio || !strcmp (subsys, "sdio")) {
> +                is_sdio = TRUE;
> +                physdev = iter;
> +                break;
>              }
>          }
>
> --
> 2.11.0.483.g087da7b7c-goog
>



-- 
Aleksander
https://aleksander.es


More information about the ModemManager-devel mailing list